cc/test/ordered_simple_task_runner_unittest.cc - Issue 2013573003: Use EXPECT_FALSE instead of EXPECT_EQ(false to fix linux build with gcc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/ordered_simple_task_runner_unittest.cc

Issue 2013573003: Use EXPECT_FALSE instead of EXPECT_EQ(false to fix linux build with gcc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/display/json_converter_unittest.cc ('k') | chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/test/ordered_simple_task_runner_unittest.cc

diff --git a/cc/test/ordered_simple_task_runner_unittest.cc b/cc/test/ordered_simple_task_runner_unittest.cc

index 3ab7ba660536e5f90f8a9e135bcdc87bd4529137..df6975bde75a36c61dc50b3aa21350877a0df614 100644

--- a/cc/test/ordered_simple_task_runner_unittest.cc

+++ b/cc/test/ordered_simple_task_runner_unittest.cc

@@ -15,7 +15,7 @@

#include "testing/gtest/include/gtest/gtest.h"

// We pass EXPECT_TRUE / EXPECT_FALSE macros rather than a boolean as on some

-// compilers EXPECT_EQ(false, XXXX) fails to compile as gtest tries to convert

+// compilers EXPECT_EQ(false, XXXX) fails to compile as gtest tries to convert

// the false value to null causing a -Werror=conversion-null error.

#define RUN_AND_CHECK_RESULT( \

tasks_remain_expect_macro, run_func, expected_result) \