Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 201353002: MediaStream API: Adding missing observer calls for remote tracks (Closed)

Created:
6 years, 9 months ago by Tommy Widenflycht
Modified:
6 years, 9 months ago
CC:
blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

MediaStream API: Adding missing observer calls for remote tracks Missed a case for remote tracks. BUG=352154 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169534

Patch Set 1 #

Patch Set 2 : Test added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
A LayoutTests/fast/mediastream/MediaStream-stop.html View 1 1 chunk +35 lines, -0 lines 0 comments Download
A + LayoutTests/fast/mediastream/MediaStream-stop-expected.txt View 1 1 chunk +4 lines, -3 lines 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Tommy Widenflycht
6 years, 9 months ago (2014-03-16 13:02:31 UTC) #1
jochen (gone - plz use gerrit)
is it possible to write a test for this?
6 years, 9 months ago (2014-03-16 13:17:12 UTC) #2
Tommy Widenflycht
On 2014/03/16 13:17:12, jochen wrote: > is it possible to write a test for this? ...
6 years, 9 months ago (2014-03-17 13:59:16 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-17 14:00:57 UTC) #4
Tommy Widenflycht
The CQ bit was checked by tommyw@chromium.org
6 years, 9 months ago (2014-03-18 15:48:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/201353002/20001
6 years, 9 months ago (2014-03-18 15:49:06 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 16:51:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-18 16:51:34 UTC) #8
Tommy Widenflycht
The CQ bit was checked by tommyw@chromium.org
6 years, 9 months ago (2014-03-19 08:25:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/201353002/20001
6 years, 9 months ago (2014-03-19 08:25:18 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 09:26:04 UTC) #11
Message was sent while issue was closed. 
Change committed as 169534

Powered by Google App Engine
This is Rietveld 408576698