Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Unified Diff: Source/modules/mediastream/MediaStream.cpp

Issue 201353002: MediaStream API: Adding missing observer calls for remote tracks (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Test added Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/mediastream/MediaStream-stop-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/mediastream/MediaStream.cpp
diff --git a/Source/modules/mediastream/MediaStream.cpp b/Source/modules/mediastream/MediaStream.cpp
index 1d7b1c133fd51208ba09d3710d79dc04fa59cb11..af0bb6324e06a5e1d5ec85e4acc6d8cd766a3e72 100644
--- a/Source/modules/mediastream/MediaStream.cpp
+++ b/Source/modules/mediastream/MediaStream.cpp
@@ -326,6 +326,7 @@ void MediaStream::addRemoteTrack(MediaStreamComponent* component)
m_videoTracks.append(track);
break;
}
+ track->addObserver(this);
m_descriptor->addComponent(component);
scheduleDispatchEvent(MediaStreamTrackEvent::create(EventTypeNames::addtrack, false, false, track));
@@ -359,6 +360,7 @@ void MediaStream::removeRemoteTrack(MediaStreamComponent* component)
m_descriptor->removeComponent(component);
RefPtr<MediaStreamTrack> track = (*tracks)[index];
+ track->removeObserver(this);
tracks->remove(index);
scheduleDispatchEvent(MediaStreamTrackEvent::create(EventTypeNames::removetrack, false, false, track));
}
« no previous file with comments | « LayoutTests/fast/mediastream/MediaStream-stop-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698