Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2013493006: Revert of Brotli compression used on about credits html file. (Closed)

Created:
4 years, 6 months ago by smaier
Modified:
4 years, 6 months ago
Reviewers:
blundell, agrieve, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Brotli compression used on about credits html file. (patchset #17 id:260001 of https://codereview.chromium.org/1951363002/ ) Reason for revert: Broke downstream x64 official builder Original issue's description: > Brotli compression used on about credits html file. > > resources.pak shrunk by 1285356B. > > To make use of brotli's compression, more of brotli's repo was added. The presubmit script had to be edited to allow the "#include ../" that was used in brotli's "tools" folder. > > BUG=332521 > > Committed: https://crrev.com/25a7bd32c100d554855af779a1a2b9dcc70a3b97 > Cr-Commit-Position: refs/heads/master@{#395920} TBR=blundell@chromium.org,sky@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=332521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -77 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 2 chunks +2 lines, -20 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_resources.gyp View 4 chunks +2 lines, -19 lines 0 comments Download
M components/resources/BUILD.gn View 3 chunks +2 lines, -12 lines 0 comments Download
M third_party/brotli/BUILD.gn View 2 chunks +5 lines, -10 lines 0 comments Download
M third_party/brotli/README.chromium View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/brotli/bro.gypi View 1 chunk +1 line, -1 line 0 comments Download
M third_party/brotli/brotli.gyp View 2 chunks +9 lines, -6 lines 0 comments Download
M third_party/brotli/tools/bro.cc View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
smaier
Created Revert of Brotli compression used on about credits html file.
4 years, 6 months ago (2016-05-26 14:30:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013493006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013493006/1
4 years, 6 months ago (2016-05-26 14:31:28 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-05-26 14:31:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013493006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013493006/1
4 years, 6 months ago (2016-05-26 14:36:09 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-05-26 14:36:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013493006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013493006/1
4 years, 6 months ago (2016-05-26 14:46:18 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-05-26 14:46:20 UTC) #12
agrieve
On 2016/05/26 14:36:11, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 6 months ago (2016-05-26 14:46:31 UTC) #13
agrieve
4 years, 6 months ago (2016-05-26 15:42:47 UTC) #14
On 2016/05/26 14:46:31, agrieve wrote:
> On 2016/05/26 14:36:11, commit-bot: I haz the power wrote:
> > No L-G-T-M from a valid reviewer yet. 
> > CQ run can only be started by full committers or once the patch has
> > received an L-G-T-M from a full committer.
> > Even if an L-G-T-M may have been provided, it was from a non-committer,
> > _not_ a full super star committer.
> > See http://www.chromium.org/getting-involved/become-a-committer
> > Note that this has nothing to do with OWNERS files.
> 
> Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=615039

Not going to revert since looks like break was for another reason (refer to bug)

Powered by Google App Engine
This is Rietveld 408576698