Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: components/components_resources.gyp

Issue 2013493006: Revert of Brotli compression used on about credits html file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser_ui.gypi ('k') | components/resources/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/components_resources.gyp
diff --git a/components/components_resources.gyp b/components/components_resources.gyp
index 9e092c276316bb670246bcfae0ea196edf770cea..783ddb42fb9cd3617fa6bbe14dd60873a50583a8 100644
--- a/components/components_resources.gyp
+++ b/components/components_resources.gyp
@@ -5,7 +5,6 @@
{
'variables': {
'about_credits_file': '<(SHARED_INTERMEDIATE_DIR)/about_credits.html',
- 'about_credits_file_bro': '<(SHARED_INTERMEDIATE_DIR)/about_credits.bro',
},
'targets': [
{
@@ -13,7 +12,7 @@
'target_name': 'components_resources',
'type': 'none',
'dependencies': [
- 'compressed_about_credits',
+ 'about_credits',
],
'hard_dependency': 1,
'variables': {
@@ -26,7 +25,7 @@
'variables': {
'grit_grd_file': 'resources/components_resources.grd',
'grit_additional_defines': [
- '-E', 'about_credits_file=<(about_credits_file_bro)',
+ '-E', 'about_credits_file=<(about_credits_file)',
],
},
'includes': [ '../build/grit_action.gypi' ],
@@ -41,22 +40,6 @@
},
],
'includes': [ '../build/grit_target.gypi' ],
- },
- {
- 'target_name': 'compressed_about_credits',
- 'type': 'none',
- 'actions': [
- {
- 'variables': {
- 'input_file': '<(about_credits_file)',
- 'output_file': '<(about_credits_file_bro)',
- },
- 'includes': ['../third_party/brotli/bro.gypi'],
- }
- ],
- 'dependencies': [
- 'about_credits'
- ],
},
{
# GN version: //components/resources:about_credits
« no previous file with comments | « chrome/chrome_browser_ui.gypi ('k') | components/resources/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698