Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2013293002: NOT FOR COMMIT: Make altgr+left and altgr+right navigate back/forward on views. (Closed)

Created:
4 years, 7 months ago by ojan
Modified:
3 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, derat+watch_chromium.org, nona+watch_chromium.org, rpop, shuchen+watch_chromium.org, James Su, tfarina, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NOT FOR COMMIT: Make altgr+left and altgr+right navigate back/forward on views. This makes them work like alt+left and alt+right so that users on European keyboard have a one-handed keyboard shortcut. A followup patch will need to make this work on Mac and ChromeOS.

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M chrome/browser/ui/views/accelerator_table.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/base/accelerators/accelerator.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/accelerators/accelerator.cc View 2 chunks +5 lines, -1 line 1 comment Download
M ui/content_accelerators/accelerator_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/combobox/combobox.cc View 1 chunk +1 line, -1 line 1 comment Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +8 lines, -1 line 2 comments Download
M ui/views/focus/focus_manager.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 10 (3 generated)
ojan
Peter, Rachel, here's the patch to make views work. Realistically, I won't be able to ...
4 years, 7 months ago (2016-05-27 00:53:54 UTC) #1
Peter Kasting
Did you select the places to add IsAltGrDown() calls by auditing all the existing IsAltDown() ...
4 years, 7 months ago (2016-05-27 01:11:01 UTC) #3
ojan
On 2016/05/27 at 01:11:01, pkasting wrote: > Did you select the places to add IsAltGrDown() ...
4 years, 7 months ago (2016-05-27 01:16:03 UTC) #4
Elliot Glaysher
On 2016/05/27 01:16:03, ojan wrote: > On 2016/05/27 at 01:11:01, pkasting wrote: > > Did ...
4 years, 6 months ago (2016-05-27 21:53:28 UTC) #6
Peter Kasting
On 2016/05/27 00:53:54, ojan wrote: > Peter, Rachel, here's the patch to make views work. ...
4 years, 4 months ago (2016-08-20 02:44:31 UTC) #8
Peter Kasting
On 2016/08/20 02:44:31, Peter Kasting wrote: > On 2016/05/27 00:53:54, ojan wrote: > > Peter, ...
3 years, 10 months ago (2017-02-11 02:04:48 UTC) #9
ojan
3 years, 10 months ago (2017-02-25 00:58:49 UTC) #10
Yeah, realistically, I just can't make time for this. Sorry. :(

On Fri, Feb 10, 2017 at 6:04 PM <pkasting@chromium.org> wrote:

> On 2016/08/20 02:44:31, Peter Kasting wrote:
> > On 2016/05/27 00:53:54, ojan wrote:
> > > Peter, Rachel, here's the patch to make views work. Realistically, I
> won't
> be
> > > able to get to finishing the one bit I comment below and adding tests
> until
> > late
> > > July. Also, of course, I won't be able to do Mac/ChromeOS before then
> either.
> >
> > It's after late July and none of the rest of us got to this :). Any
> chance
> you
> > can pick this back up?
>
> I'm guessing from the lack of response the answer was "no"... but this is
> still
> relevant :)
>
> https://codereview.chromium.org/2013293002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698