Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: ui/views/controls/combobox/combobox.cc

Issue 2013293002: NOT FOR COMMIT: Make altgr+left and altgr+right navigate back/forward on views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/combobox/combobox.cc
diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc
index dc7797936b73c56c043e2d2873986603ab04804f..693d8fd46b4bb64f1f98d965a1aadea6e4e42274 100644
--- a/ui/views/controls/combobox/combobox.cc
+++ b/ui/views/controls/combobox/combobox.cc
@@ -540,7 +540,7 @@ const char* Combobox::GetClassName() const {
bool Combobox::SkipDefaultKeyEventProcessing(const ui::KeyEvent& e) {
// Escape should close the drop down list when it is active, not host UI.
if (e.key_code() != ui::VKEY_ESCAPE ||
- e.IsShiftDown() || e.IsControlDown() || e.IsAltDown()) {
+ e.IsShiftDown() || e.IsControlDown() || e.IsAltDown() || e.IsAltGrDown()) {
Peter Kasting 2016/05/27 01:11:01 Nit: 80 columns
return false;
}
return !!menu_runner_;

Powered by Google App Engine
This is Rietveld 408576698