Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2013193002: Turbofan: Rename IsFloat -> IsFP (Closed)

Created:
4 years, 7 months ago by bbudge
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turbofan: Rename IsFloat -> IsFP Rename some methods to reflect the fact that there are multiple FP machine representations. LOG=N BUG=v8:4124 Committed: https://crrev.com/270a284fd07e182a99ba4e0a7fd03b9a65e896e3 Cr-Commit-Position: refs/heads/master@{#36552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction.h View 1 chunk +9 lines, -1 line 0 comments Download
M src/compiler/register-allocator-verifier.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bbudge
4 years, 7 months ago (2016-05-26 23:48:40 UTC) #2
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-27 03:52:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013193002/1
4 years, 6 months ago (2016-05-27 17:41:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 17:43:44 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 17:44:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/270a284fd07e182a99ba4e0a7fd03b9a65e896e3
Cr-Commit-Position: refs/heads/master@{#36552}

Powered by Google App Engine
This is Rietveld 408576698