chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm - Issue 2013183003: [Mac][Material Design] Bring Omnibox stroke and MD colors up to spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

Issue 2013183003: [Mac][Material Design] Bring Omnibox stroke and MD colors up to spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile error. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

index 67635d36ec48c4479f9524b3fcfdbfc0b3510af7..7287734a46ce45d61fa7c4638080fac7d7dd4be4 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

@@ -112,10 +112,16 @@ NSColor* DimTextColor(BOOL is_dark_theme) {

return skia::SkColorToSRGBNSColor(SkColorSetRGB(0x64, 0x64, 0x64));

}

NSColor* PositiveTextColor() {

- return skia::SkColorToCalibratedNSColor(SkColorSetRGB(0x3d, 0x94, 0x00));

+ if (!ui::MaterialDesignController::IsModeMaterial()) {

+ return skia::SkColorToCalibratedNSColor(SkColorSetRGB(0x3d, 0x94, 0x00));

+ }

+ return skia::SkColorToSRGBNSColor(SkColorSetRGB(0x3d, 0x94, 0x00));

}

NSColor* NegativeTextColor() {

- return skia::SkColorToCalibratedNSColor(SkColorSetRGB(0xdd, 0x4b, 0x39));

+ if (!ui::MaterialDesignController::IsModeMaterial()) {

+ return skia::SkColorToCalibratedNSColor(SkColorSetRGB(0xdd, 0x4b, 0x39));

+ }

+ return skia::SkColorToSRGBNSColor(SkColorSetRGB(0xdd, 0x4b, 0x39));

}

NSColor* URLTextColor(BOOL is_dark_theme) {

if (!ui::MaterialDesignController::IsModeMaterial()) {