Issue 201313002: Fix ASSERT violation when BinaryOpIC::Transition recurses into itself

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201313002: Fix ASSERT violation when BinaryOpIC::Transition recurses into itself (Closed)

Created:
6 years, 9 months ago by Jakob Kummerow

Modified:
6 years, 9 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix ASSERT violation when BinaryOpIC::Transition recurses into itself BUG=chromium:352586 LOG=n R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20000

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -11 lines)			Patch
M	src/ic.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/ic.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-352586.js	View		1 chunk	+8 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

PTAL. Let me know if you have an idea for a better fix.

6 years, 9 months ago (2014-03-17 13:39:30 UTC) #1

Jakob Kummerow

6 years, 9 months ago (2014-03-17 14:51:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20000 (presubmit successful).