Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/ic.h

Issue 201313002: Fix ASSERT violation when BinaryOpIC::Transition recurses into itself (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: refactored Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 240
241 bool TryRemoveInvalidPrototypeDependentStub(Handle<Object> receiver, 241 bool TryRemoveInvalidPrototypeDependentStub(Handle<Object> receiver,
242 Handle<String> name); 242 Handle<String> name);
243 void TryRemoveInvalidHandlers(Handle<Map> map, Handle<String> name); 243 void TryRemoveInvalidHandlers(Handle<Map> map, Handle<String> name);
244 244
245 ExtraICState extra_ic_state() const { return extra_ic_state_; } 245 ExtraICState extra_ic_state() const { return extra_ic_state_; }
246 void set_extra_ic_state(ExtraICState state) { 246 void set_extra_ic_state(ExtraICState state) {
247 extra_ic_state_ = state; 247 extra_ic_state_ = state;
248 } 248 }
249 249
250 protected:
251 void UpdateTarget() {
252 target_ = handle(raw_target(), isolate_);
253 }
254
250 private: 255 private:
251 Code* raw_target() const { 256 Code* raw_target() const {
252 return GetTargetAtAddress(address(), constant_pool()); 257 return GetTargetAtAddress(address(), constant_pool());
253 } 258 }
254 inline ConstantPoolArray* constant_pool() const; 259 inline ConstantPoolArray* constant_pool() const;
255 inline ConstantPoolArray* raw_constant_pool() const; 260 inline ConstantPoolArray* raw_constant_pool() const;
256 261
257 // Frame pointer for the frame that uses (calls) the IC. 262 // Frame pointer for the frame that uses (calls) the IC.
258 Address fp_; 263 Address fp_;
259 264
(...skipping 662 matching lines...) Expand 10 before | Expand all | Expand 10 after
922 DECLARE_RUNTIME_FUNCTION(MaybeObject*, ElementsTransitionAndStoreIC_Miss); 927 DECLARE_RUNTIME_FUNCTION(MaybeObject*, ElementsTransitionAndStoreIC_Miss);
923 DECLARE_RUNTIME_FUNCTION(MaybeObject*, BinaryOpIC_Miss); 928 DECLARE_RUNTIME_FUNCTION(MaybeObject*, BinaryOpIC_Miss);
924 DECLARE_RUNTIME_FUNCTION(MaybeObject*, BinaryOpIC_MissWithAllocationSite); 929 DECLARE_RUNTIME_FUNCTION(MaybeObject*, BinaryOpIC_MissWithAllocationSite);
925 DECLARE_RUNTIME_FUNCTION(MaybeObject*, CompareNilIC_Miss); 930 DECLARE_RUNTIME_FUNCTION(MaybeObject*, CompareNilIC_Miss);
926 DECLARE_RUNTIME_FUNCTION(MaybeObject*, ToBooleanIC_Miss); 931 DECLARE_RUNTIME_FUNCTION(MaybeObject*, ToBooleanIC_Miss);
927 932
928 933
929 } } // namespace v8::internal 934 } } // namespace v8::internal
930 935
931 #endif // V8_IC_H_ 936 #endif // V8_IC_H_
OLDNEW
« no previous file with comments | « no previous file | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698