Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2013093002: Summarize references to closure parameters properly. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -30 lines) Patch
M pkg/analyzer/lib/src/summary/format.fbs View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 5 chunks +27 lines, -11 lines 2 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 4 chunks +51 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-26 16:50:55 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2013093002/diff/1/pkg/analyzer/lib/src/summary/summarize_ast.dart File pkg/analyzer/lib/src/summary/summarize_ast.dart (right): https://codereview.chromium.org/2013093002/diff/1/pkg/analyzer/lib/src/summary/summarize_ast.dart#newcode40 pkg/analyzer/lib/src/summary/summarize_ast.dart:40: * If the expression being serialize appears inside ...
4 years, 7 months ago (2016-05-26 16:59:33 UTC) #3
Paul Berry
https://codereview.chromium.org/2013093002/diff/1/pkg/analyzer/lib/src/summary/summarize_ast.dart File pkg/analyzer/lib/src/summary/summarize_ast.dart (right): https://codereview.chromium.org/2013093002/diff/1/pkg/analyzer/lib/src/summary/summarize_ast.dart#newcode40 pkg/analyzer/lib/src/summary/summarize_ast.dart:40: * If the expression being serialize appears inside a ...
4 years, 7 months ago (2016-05-26 17:04:23 UTC) #4
Paul Berry
4 years, 7 months ago (2016-05-26 17:04:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e71e111b2432c4bb48b12816b2510f4a059a9063 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698