Summarize references to closure parameters properly.

pkg/analyzer/lib/src/summary/summarize_const_expr.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library serialization.summarize_const_expr;
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/element/type.dart' show DartType;
 import 'package:analyzer/src/summary/format.dart';
@@ skipping 84 matching lines @@
    * See [UnlinkedConstBuilder.strings].
    */
   final List<String> strings = <String>[];
 
   /**
    * See [UnlinkedConstBuilder.references].
    */
   final List<EntityRefBuilder> references = <EntityRefBuilder>[];
 
   /**
-   * Return `true` if a constructor initializer expression is being serialized
-   * and the given [name] is a constructor parameter reference.
+   * Return `true` if the given [name] is a parameter reference.
    */
-  bool isConstructorParameterName(String name);
+  bool isParameterName(String name);
 
   /**
    * Serialize the given [expr] expression into this serializer state.
    */
   void serialize(Expression expr) {
     try {
       if (expr is NamedExpression) {
         NamedExpression namedExpression = expr;
         name = namedExpression.name.label.name;
         expr = namedExpression.expression;
@@ skipping 141 matching lines @@
         operations.add(UnlinkedConstOperation.pushFalse);
       }
     } else if (expr is StringLiteral) {
       _serializeString(expr);
     } else if (expr is SymbolLiteral) {
       strings.add(expr.components.map((token) => token.lexeme).join('.'));
       operations.add(UnlinkedConstOperation.makeSymbol);
     } else if (expr is NullLiteral) {
       operations.add(UnlinkedConstOperation.pushNull);
     } else if (expr is Identifier) {
-      if (expr is SimpleIdentifier && isConstructorParameterName(expr.name)) {
+      if (expr is SimpleIdentifier && isParameterName(expr.name)) {
         strings.add(expr.name);
-        operations.add(UnlinkedConstOperation.pushConstructorParameter);
+        operations.add(UnlinkedConstOperation.pushParameter);
       } else {
         references.add(serializeIdentifier(expr));
         operations.add(UnlinkedConstOperation.pushReference);
       }
     } else if (expr is InstanceCreationExpression) {
       if (!expr.isConst) {
         isValidConst = false;
       }
       TypeName typeName = expr.constructorName.type;
       serializeInstanceCreation(
@@ skipping 332 matching lines @@
         expr = (expr as PrefixedIdentifier).prefix;
       } else if (expr is PropertyAccess) {
         expr = (expr as PropertyAccess).target;
       } else {
         return false;
       }
     }
     return false;
   }
 }