Issue 2012993002: Remove the app launcher promo code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2012993002: Remove the app launcher promo code

Created:
4 years, 7 months ago by tapted

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, tapted, Matt Giuca, tfarina, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove the app launcher promo code BUG=600915 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -223 lines)			Patch
M	apps/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	apps/apps.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	apps/metrics_names.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	chrome/browser/resources/ntp4/app_launcher_promo.png	View	Binary file		0 comments	Download
M	chrome/browser/resources/ntp4/apps_page.css	View	1 chunk	+0 lines, -61 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.html	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.js	View	1 chunk	+2 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/ntp4/page_list_view.js	View	3 chunks	+1 line, -22 lines	0 comments	Download
M	chrome/browser/ui/app_list/app_list_service.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/app_list/app_list_util.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/app_list/app_list_util.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.h	View	3 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.cc	View	8 chunks	+5 lines, -53 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache.cc	View	3 chunks	+0 lines, -15 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tapted

4 years, 7 months ago (2016-05-26 03:17:38 UTC) #1

Description was changed from

==========
Remove the app launcher promo code


BUG=600915
==========

to

==========
Remove the app launcher promo code


BUG=600915
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages