Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6935)

Unified Diff: chrome/browser/resources/ntp4/page_list_view.js

Issue 2012993002: Remove the app launcher promo code Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/ntp4/new_tab.js ('k') | chrome/browser/ui/app_list/app_list_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/page_list_view.js
diff --git a/chrome/browser/resources/ntp4/page_list_view.js b/chrome/browser/resources/ntp4/page_list_view.js
index efb31fe47c32488fb49689b591acb1ff74266eeb..370c42e138023451712e036ea1767138529f955a 100644
--- a/chrome/browser/resources/ntp4/page_list_view.js
+++ b/chrome/browser/resources/ntp4/page_list_view.js
@@ -407,7 +407,6 @@ cr.define('ntp', function() {
this.appsLoaded_ = true;
cr.dispatchSimpleEvent(document, 'sectionready', true, true);
}
- this.updateAppLauncherPromoHiddenState_();
},
/**
@@ -469,25 +468,6 @@ cr.define('ntp', function() {
},
/**
- * Callback invoked by chrome whenever the app launcher promo pref changes.
- * @param {boolean} show Identifies if we should show or hide the promo.
- */
- appLauncherPromoPrefChangeCallback: function(show) {
- loadTimeData.overrideValues({showAppLauncherPromo: show});
- this.updateAppLauncherPromoHiddenState_();
- },
-
- /**
- * Updates the hidden state of the app launcher promo based on the page
- * shown and load data content.
- * @private
- */
- updateAppLauncherPromoHiddenState_: function() {
- $('app-launcher-promo').hidden =
- !loadTimeData.getBoolean('showAppLauncherPromo');
- },
-
- /**
* Invoked whenever the pages in apps-page-list have changed so that
* the Slider knows about the new elements.
*/
@@ -646,8 +626,7 @@ cr.define('ntp', function() {
setShownPage_: function(shownPageIndex) {
assert(shownPageIndex >= 0);
this.shownPageIndex = shownPageIndex;
- chrome.send('pageSelected', [this.shownPageIndex]);
- this.updateAppLauncherPromoHiddenState_();
+ chrome.send('pageSelected', [this.shownPage, this.shownPageIndex]);
},
/**
« no previous file with comments | « chrome/browser/resources/ntp4/new_tab.js ('k') | chrome/browser/ui/app_list/app_list_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698