Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2012943002: Merge "SELECT popup: Do not update popup content for arbitrary attribute change." to M52. (Closed)

Created:
4 years, 6 months ago by tkent
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Merge "SELECT popup: Do not update popup content for arbitrary attribute change." to M52. In the site of crbug.com/615250, mousedown event handler for a SELECT element sets and deletes id attribute of the SELECT element. We shouldn't try to update popup content in such case. BUG=614250 Review-Url: https://codereview.chromium.org/2012653002 Cr-Commit-Position: refs/heads/master@{#395818} (cherry picked from commit 194ad8e687efc243d3b836a648697aaab394fbf0) Committed: https://chromium.googlesource.com/chromium/src/+/265054928b149e423dc8950e7222b642a092e0cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years, 6 months ago (2016-05-25 22:54:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
265054928b149e423dc8950e7222b642a092e0cb.

Powered by Google App Engine
This is Rietveld 408576698