Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2012653002: SELECT popup: Do not update popup content for arbitrary attribute change. (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT popup: Do not update popup content for arbitrary attribute change. In the site of crbug.com/615250, mousedown event handler for a SELECT element sets and deletes id attribute of the SELECT element. We shouldn't try to update popup content in such case. BUG=614250 Committed: https://crrev.com/194ad8e687efc243d3b836a648697aaab394fbf0 Cr-Commit-Position: refs/heads/master@{#395818}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
Keishi, would you review this please?
4 years, 7 months ago (2016-05-25 05:39:37 UTC) #5
keishi
LGTM
4 years, 7 months ago (2016-05-25 06:55:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012653002/20001
4 years, 7 months ago (2016-05-25 06:58:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-25 07:02:24 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 07:03:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/194ad8e687efc243d3b836a648697aaab394fbf0
Cr-Commit-Position: refs/heads/master@{#395818}

Powered by Google App Engine
This is Rietveld 408576698