Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2012843004: [merge-m52] Avoid clobbering the app list pinned taskbar shortcut on startup (for now). (Closed)

Created:
4 years, 7 months ago by tapted
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[merge-m52] Avoid clobbering the app list pinned taskbar shortcut on startup (for now). This is a partial revert of r393415 which removed checking for --show-app-list from shell_integration_win.cc's GetExpectedAppId(). This meant that the expected app_id for app launcher shortcuts would now be the same as regular Chrome. MigrateTaskbarPinsCallback() then successfully updates the app_id for the existing App Launcher shortcut, but Windows immediately sees 2 pinned apps for the same app_id and clobbers one of them. To fix, we need to keep the old app_id around for a bit longer. The shortcuts will be removed properly in a later milestone (from the taskbar as well as other places which are not currently clobbered by coincidence). BUG=613789 Review-Url: https://codereview.chromium.org/2005163002 Cr-Commit-Position: refs/heads/master@{#395785} (cherry picked from commit c2c690ab31976ed7bd715709606f736085d6b43e) Committed: https://chromium.googlesource.com/chromium/src/+/6245e3c98aca06ea1ecc285ea3d764d9fc677122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/shell_integration_win.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
tapted
4 years, 7 months ago (2016-05-26 12:53:42 UTC) #1
tapted
4 years, 7 months ago (2016-05-26 13:00:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6245e3c98aca06ea1ecc285ea3d764d9fc677122.

Powered by Google App Engine
This is Rietveld 408576698