Avoid clobbering the app list pinned taskbar shortcut on startup (for now).

Avoid clobbering the app list pinned taskbar shortcut on startup (for now).

This is a partial revert of r393415 which removed checking for
--show-app-list from shell_integration_win.cc's GetExpectedAppId(). This
meant that the expected app_id for app launcher shortcuts would now be
the same as regular Chrome.

MigrateTaskbarPinsCallback() then successfully updates the app_id for
the existing App Launcher shortcut, but Windows immediately sees 2
pinned apps for the same app_id and clobbers one of them.

To fix, we need to keep the old app_id around for a bit longer. The
shortcuts will be removed properly in a later milestone (from the
taskbar as well as other places which are not currently clobbered by
coincidence).

BUG=613789
Committed: https://crrev.com/c2c690ab31976ed7bd715709606f736085d6b43e
Cr-Commit-Position: refs/heads/master@{#395785}

[tapted, 2016-05-24 05:45:49]

Description was changed from

==========
Avoid clobbering the app list shortcut on startup (for now).

This is a partial revert of r393415 which removed checking for
--show-app-list from shell_integration_win.cc's GetExpectedAppId(). This
meant that the expected app_id for app launcher shortcuts would now be
the same as regular Chrome.

MigrateTaskbarPinsCallback() then successfully updates the app_id, but
Windows immediately sees 2 pinned apps for the same app_id and clobbers
one of them.

The shortcuts will be removed properly in a later milestone (from the
taskbar as well as other places which are not currently clobbered by
coincidence).

BUG=613789
==========

to

==========
Avoid clobbering the app list shortcut on startup (for now).

This is a partial revert of r393415 which removed checking for
--show-app-list from shell_integration_win.cc's GetExpectedAppId(). This
meant that the expected app_id for app launcher shortcuts would now be
the same as regular Chrome.

MigrateTaskbarPinsCallback() then successfully updates the app_id, but
Windows immediately sees 2 pinned apps for the same app_id and clobbers
one of them.

To fix, we need to keep the old app_id around for a bit longer. The
shortcuts will be removed properly in a later milestone (from the
taskbar as well as other places which are not currently clobbered by
coincidence).

BUG=613789
==========

[tapted, 2016-05-24 05:45:49]

tapted@chromium.org changed reviewers:
+ gab@chromium.org

[tapted, 2016-05-24 05:46:39]

Description was changed from

==========
Avoid clobbering the app list shortcut on startup (for now).

This is a partial revert of r393415 which removed checking for
--show-app-list from shell_integration_win.cc's GetExpectedAppId(). This
meant that the expected app_id for app launcher shortcuts would now be
the same as regular Chrome.

MigrateTaskbarPinsCallback() then successfully updates the app_id, but
Windows immediately sees 2 pinned apps for the same app_id and clobbers
one of them.

To fix, we need to keep the old app_id around for a bit longer. The
shortcuts will be removed properly in a later milestone (from the
taskbar as well as other places which are not currently clobbered by
coincidence).

BUG=613789
==========

to

==========
Avoid clobbering the app list shortcut on startup (for now).

This is a partial revert of r393415 which removed checking for
--show-app-list from shell_integration_win.cc's GetExpectedAppId(). This
meant that the expected app_id for app launcher shortcuts would now be
the same as regular Chrome.

MigrateTaskbarPinsCallback() then successfully updates the app_id for
the existing App Launcher shortcut, but Windows immediately sees 2
pinned apps for the same app_id and clobbers one of them.

To fix, we need to keep the old app_id around for a bit longer. The
shortcuts will be removed properly in a later milestone (from the
taskbar as well as other places which are not currently clobbered by
coincidence).

BUG=613789
==========

[tapted, 2016-05-24 05:47:33]

Description was changed from

==========
Avoid clobbering the app list shortcut on startup (for now).

This is a partial revert of r393415 which removed checking for
--show-app-list from shell_integration_win.cc's GetExpectedAppId(). This
meant that the expected app_id for app launcher shortcuts would now be
the same as regular Chrome.

MigrateTaskbarPinsCallback() then successfully updates the app_id for
the existing App Launcher shortcut, but Windows immediately sees 2
pinned apps for the same app_id and clobbers one of them.

To fix, we need to keep the old app_id around for a bit longer. The
shortcuts will be removed properly in a later milestone (from the
taskbar as well as other places which are not currently clobbered by
coincidence).

BUG=613789
==========

to

==========
Avoid clobbering the app list pinned taskbar shortcut on startup (for now).

This is a partial revert of r393415 which removed checking for
--show-app-list from shell_integration_win.cc's GetExpectedAppId(). This
meant that the expected app_id for app launcher shortcuts would now be
the same as regular Chrome.

MigrateTaskbarPinsCallback() then successfully updates the app_id for
the existing App Launcher shortcut, but Windows immediately sees 2
pinned apps for the same app_id and clobbers one of them.

To fix, we need to keep the old app_id around for a bit longer. The
shortcuts will be removed properly in a later milestone (from the
taskbar as well as other places which are not currently clobbered by
coincidence).

BUG=613789
==========

[tapted, 2016-05-24 08:07:26]

Hi gab, please take a look

[gab, 2016-05-24 16:01:25]

lgtm w/ nits

https://codereview.chromium.org/2005163002/diff/1/chrome/browser/shell_integr...
File chrome/browser/shell_integration_win.cc (right):

https://codereview.chromium.org/2005163002/diff/1/chrome/browser/shell_integr...
chrome/browser/shell_integration_win.cc:62: const wchar_t
kAppListAppNameSuffix[] = L"AppList";
s/wchar_t/base::char16/

(identical on Windows but makes more semantical sense since it's appended to a
base::string16)

https://codereview.chromium.org/2005163002/diff/1/chrome/browser/shell_integr...
chrome/browser/shell_integration_win.cc:62: const wchar_t
kAppListAppNameSuffix[] = L"AppList";
Inline as a "static base::char16[]" in GetAppListAppName().

[tapted, 2016-05-25 00:32:42]

Thanks gab!

https://codereview.chromium.org/2005163002/diff/1/chrome/browser/shell_integr...
File chrome/browser/shell_integration_win.cc (right):

https://codereview.chromium.org/2005163002/diff/1/chrome/browser/shell_integr...
chrome/browser/shell_integration_win.cc:62: const wchar_t
kAppListAppNameSuffix[] = L"AppList";
On 2016/05/24 16:01:25, gab wrote:
> s/wchar_t/base::char16/
> 
> (identical on Windows but makes more semantical sense since it's appended to a
> base::string16)

Done.

https://codereview.chromium.org/2005163002/diff/1/chrome/browser/shell_integr...
chrome/browser/shell_integration_win.cc:62: const wchar_t
kAppListAppNameSuffix[] = L"AppList";
On 2016/05/24 16:01:24, gab wrote:
> Inline as a "static base::char16[]" in GetAppListAppName().

Done.

[tapted, 2016-05-25 00:32:57]

The CQ bit was checked by tapted@chromium.org

[tapted, 2016-05-25 00:32:57]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2005163002/#ps20001
(title: "respond to comments")

[commit-bot: I haz the power, 2016-05-25 00:34:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2005163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2005163002/20001

[commit-bot: I haz the power, 2016-05-25 02:49:17]

Description was changed from

==========
Avoid clobbering the app list pinned taskbar shortcut on startup (for now).

This is a partial revert of r393415 which removed checking for
--show-app-list from shell_integration_win.cc's GetExpectedAppId(). This
meant that the expected app_id for app launcher shortcuts would now be
the same as regular Chrome.

MigrateTaskbarPinsCallback() then successfully updates the app_id for
the existing App Launcher shortcut, but Windows immediately sees 2
pinned apps for the same app_id and clobbers one of them.

To fix, we need to keep the old app_id around for a bit longer. The
shortcuts will be removed properly in a later milestone (from the
taskbar as well as other places which are not currently clobbered by
coincidence).

BUG=613789
==========

to

==========
Avoid clobbering the app list pinned taskbar shortcut on startup (for now).

This is a partial revert of r393415 which removed checking for
--show-app-list from shell_integration_win.cc's GetExpectedAppId(). This
meant that the expected app_id for app launcher shortcuts would now be
the same as regular Chrome.

MigrateTaskbarPinsCallback() then successfully updates the app_id for
the existing App Launcher shortcut, but Windows immediately sees 2
pinned apps for the same app_id and clobbers one of them.

To fix, we need to keep the old app_id around for a bit longer. The
shortcuts will be removed properly in a later milestone (from the
taskbar as well as other places which are not currently clobbered by
coincidence).

BUG=613789
==========

[commit-bot: I haz the power, 2016-05-25 02:49:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-25 02:50:51]

Description was changed from

==========
Avoid clobbering the app list pinned taskbar shortcut on startup (for now).

This is a partial revert of r393415 which removed checking for
--show-app-list from shell_integration_win.cc's GetExpectedAppId(). This
meant that the expected app_id for app launcher shortcuts would now be
the same as regular Chrome.

MigrateTaskbarPinsCallback() then successfully updates the app_id for
the existing App Launcher shortcut, but Windows immediately sees 2
pinned apps for the same app_id and clobbers one of them.

To fix, we need to keep the old app_id around for a bit longer. The
shortcuts will be removed properly in a later milestone (from the
taskbar as well as other places which are not currently clobbered by
coincidence).

BUG=613789
==========

to

==========
Avoid clobbering the app list pinned taskbar shortcut on startup (for now).

This is a partial revert of r393415 which removed checking for
--show-app-list from shell_integration_win.cc's GetExpectedAppId(). This
meant that the expected app_id for app launcher shortcuts would now be
the same as regular Chrome.

MigrateTaskbarPinsCallback() then successfully updates the app_id for
the existing App Launcher shortcut, but Windows immediately sees 2
pinned apps for the same app_id and clobbers one of them.

To fix, we need to keep the old app_id around for a bit longer. The
shortcuts will be removed properly in a later milestone (from the
taskbar as well as other places which are not currently clobbered by
coincidence).

BUG=613789

Committed: https://crrev.com/c2c690ab31976ed7bd715709606f736085d6b43e
Cr-Commit-Position: refs/heads/master@{#395785}
==========

[commit-bot: I haz the power, 2016-05-25 02:50:52]

Patchset 2 (id:??) landed as
https://crrev.com/c2c690ab31976ed7bd715709606f736085d6b43e
Cr-Commit-Position: refs/heads/master@{#395785}