Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2012773005: Simplify notification of a dirty listener. (Closed)

Created:
4 years, 7 months ago by Raymond Toy
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Simplify notification of a dirty listener. Instead of the listener updating the dirty state of all panners, just set a dirty state flag in the listener. Then, when a panner needs to compute a new azimuth/elevation gain or cone gain, the panner just checks to see if the listener is dirty. This gets rid of the data race where both the audio thread and the main thread are updating the dirty state of a panner. The checking and setting of the listener state happens on the audio thread. The race from reading from the hash table of panners in AudioListener and adding to the table from the main thread is also removed. BUG=612948, 612955, 613332 TEST=none Review-Url: https://codereview.chromium.org/2006563003 Cr-Commit-Position: refs/heads/master@{#395738} (cherry picked from commit a6beb9f31fba1c7892fbfb4911f34e5a13492183) Committed: https://chromium.googlesource.com/chromium/src/+/84ecd66b39c24e7614412f08571b98380d7cd41d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -21 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AudioListener.h View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioListener.cpp View 5 chunks +32 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PannerNode.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PannerNode.cpp View 4 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Raymond Toy
4 years, 7 months ago (2016-05-26 17:19:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
84ecd66b39c24e7614412f08571b98380d7cd41d.

Powered by Google App Engine
This is Rietveld 408576698