Simplify notification of a dirty listener.

third_party/WebKit/Source/modules/webaudio/PannerNode.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 130 matching lines @@
         if (hasSampleAccurateValues() || listener()->hasSampleAccurateValues()) {
             // It's tempting to skip sample-accurate processing if isAzimuthElevationDirty() and
             // isDistanceConeGain() both return false.  But in general we can't because something
             // may scheduled to start in the middle of the rendering quantum.  On the other hand,
             // the audible effect may be small enough that we can afford to do this optimization.
             processSampleAccurateValues(destination, source, framesToProcess);
         } else {
             // Apply the panning effect.
             double azimuth;
             double elevation;
+
+            // Update dirty state in case something has moved; this can happen if the AudioParam for
+            // the position or orientation component is set directly.
+            updateDirtyState();
+
             azimuthElevation(&azimuth, &elevation);
 
             m_panner->pan(azimuth, elevation, source, destination, framesToProcess);
 
             // Get the distance and cone gain.
             float totalGain = distanceConeGain();
 
             m_lastGain = totalGain;
 
             // Apply gain in-place with de-zippering.
@@ skipping 339 matching lines @@
     double distanceGain = m_distanceEffect.gain(listenerDistance);
     double coneGain = m_coneEffect.gain(position, orientation, listenerPosition);
 
     return float(distanceGain * coneGain);
 }
 
 void PannerHandler::azimuthElevation(double* outAzimuth, double* outElevation)
 {
     ASSERT(context()->isAudioThread());
 
-    if (isAzimuthElevationDirty()) {
+    // Calculate new azimuth and elevation if the panner or the listener changed
+    // position or orientation in any way.
+    if (isAzimuthElevationDirty() || listener()->isListenerDirty()) {
         calculateAzimuthElevation(
             &m_cachedAzimuth,
             &m_cachedElevation,
             position(),
             listener()->position(),
             listener()->orientation(),
             listener()->upVector());
         m_isAzimuthElevationDirty = false;
     }
 
     *outAzimuth = m_cachedAzimuth;
     *outElevation = m_cachedElevation;
 }
 
 float PannerHandler::distanceConeGain()
 {
     ASSERT(context()->isAudioThread());
 
-    if (isDistanceConeGainDirty()) {
+    // Calculate new distance and cone gain if the panner or the listener
+    // changed position or orientation in any way.
+    if (isDistanceConeGainDirty() || listener()->isListenerDirty()) {
         m_cachedDistanceConeGain = calculateDistanceConeGain(position(), orientation(), listener()->position());
         m_isDistanceConeGainDirty = false;
     }
 
     return m_cachedDistanceConeGain;
 }
 
 void PannerHandler::markPannerAsDirty(unsigned dirty)
 {
     if (dirty & PannerHandler::AzimuthElevationDirty)
@@ skipping 59 matching lines @@
     return m_positionX->hasSampleAccurateValues()
         || m_positionY->hasSampleAccurateValues()
         || m_positionZ->hasSampleAccurateValues()
         || m_orientationX->hasSampleAccurateValues()
         || m_orientationY->hasSampleAccurateValues()
         || m_orientationZ->hasSampleAccurateValues();
 }
 
 void PannerHandler::updateDirtyState()
 {
+    DCHECK(context()->isAudioThread());
+
     FloatPoint3D currentPosition = position();
     FloatPoint3D currentOrientation = orientation();
 
     bool hasMoved = currentPosition != m_lastPosition
         || currentOrientation != m_lastOrientation;
 
     if (hasMoved) {
         m_lastPosition = currentPosition;
         m_lastOrientation = currentOrientation;
 
@@ skipping 135 matching lines @@
     visitor->trace(m_positionZ);
 
     visitor->trace(m_orientationX);
     visitor->trace(m_orientationY);
     visitor->trace(m_orientationZ);
 
     AudioNode::trace(visitor);
 }
 
 } // namespace blink