Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Issue 2012763005: Remove the simplified-fullscreen-ui flag on Mac. (Closed)

Created:
4 years, 7 months ago by Matt Giuca
Modified:
4 years, 7 months ago
Reviewers:
tapted, scheib
CC:
chromium-reviews, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the simplified-fullscreen-ui flag on Mac. Now the flag is permanently enabled (which it already was by default). Required so we can start removing the Cocoa code and we don't want to have to add Mac-specific support for the non-simplified version on Views. BUG=610900 Committed: https://crrev.com/1a7f91857493839c1dd02f46984b956218d911c3 Cr-Commit-Position: refs/heads/master@{#396355}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Disable the right flag ;) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/exclusive_access/exclusive_access_manager.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (4 generated)
Matt Giuca
4 years, 7 months ago (2016-05-26 05:37:37 UTC) #2
Matt Giuca
4 years, 7 months ago (2016-05-26 05:37:47 UTC) #4
Matt Giuca
https://codereview.chromium.org/2012763005/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/2012763005/diff/1/chrome/browser/about_flags.cc#newcode1595 chrome/browser/about_flags.cc:1595: kOsWin | kOsLinux | kOsCrOS | kOsAndroid, Um wait ...
4 years, 7 months ago (2016-05-26 05:42:05 UTC) #5
Matt Giuca
https://codereview.chromium.org/2012763005/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/2012763005/diff/1/chrome/browser/about_flags.cc#newcode1595 chrome/browser/about_flags.cc:1595: kOsWin | kOsLinux | kOsCrOS | kOsAndroid, On 2016/05/26 ...
4 years, 7 months ago (2016-05-26 05:46:32 UTC) #6
tapted
lgtm
4 years, 7 months ago (2016-05-26 05:49:17 UTC) #7
scheib
LGTM
4 years, 7 months ago (2016-05-26 17:44:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012763005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012763005/20001
4 years, 7 months ago (2016-05-27 00:29:41 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-27 02:12:58 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-27 02:14:30 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a7f91857493839c1dd02f46984b956218d911c3
Cr-Commit-Position: refs/heads/master@{#396355}

Powered by Google App Engine
This is Rietveld 408576698