Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 2008813002: Remove the simplified-fullscreen-ui flag on Android. (Closed)

Created:
4 years, 7 months ago by Matt Giuca
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Ted C
CC:
chromium-reviews, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, Theresa
Base URL:
https://chromium.googlesource.com/chromium/src.git@android-fullscreen-settings-deprecation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the simplified-fullscreen-ui flag on Android. Now the flag is permanently enabled. Cleaned up some code that is no longer used because of this change. The FullscreenInfoBarDelegate class is no longer used but this will be deleted in a follow-up CL. BUG=610900 Committed: https://crrev.com/a47af6863779505af7776102bc5390234a985476 Cr-Commit-Position: refs/heads/master@{#398448}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Fix compile. #

Messages

Total messages: 33 (18 generated)
Matt Giuca
thestig@chromium.org: Please review changes in chrome_features.cc. tedchoc@chromium.org: Please review changes in chrome/android. Follow-up CL pending: ...
4 years, 7 months ago (2016-05-27 00:41:26 UTC) #2
Matt Giuca
Hi Theresa, as Ted is OOO, perhaps you could look at chrome/android instead?
4 years, 7 months ago (2016-05-27 00:42:10 UTC) #4
Lei Zhang
non-Android bits lgtm
4 years, 7 months ago (2016-05-27 00:52:39 UTC) #5
Ted C
lgtm
4 years, 6 months ago (2016-05-31 19:52:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008813002/20001
4 years, 6 months ago (2016-06-01 00:56:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/13956) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-01 01:00:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008813002/40001
4 years, 6 months ago (2016-06-06 04:18:27 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/77032)
4 years, 6 months ago (2016-06-06 05:21:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008813002/80001
4 years, 6 months ago (2016-06-07 05:55:04 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/159311)
4 years, 6 months ago (2016-06-07 06:26:50 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008813002/80001
4 years, 6 months ago (2016-06-07 06:45:05 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/159324)
4 years, 6 months ago (2016-06-07 07:05:46 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008813002/80001
4 years, 6 months ago (2016-06-08 00:33:05 UTC) #29
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 6 months ago (2016-06-08 01:24:20 UTC) #31
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 01:25:55 UTC) #33
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a47af6863779505af7776102bc5390234a985476
Cr-Commit-Position: refs/heads/master@{#398448}

Powered by Google App Engine
This is Rietveld 408576698