Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2103)

Unified Diff: components/autofill/content/renderer/autofill_agent.h

Issue 2012763003: First pass at refactoring autofill_agent to eventually incorporate Synthetic Form logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.h
diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h
index aaf357670086c8b8c2ed4e2be291121a47c4a5fe..40c39172d359b4b0f66a8de3117850642dcbaaa1 100644
--- a/components/autofill/content/renderer/autofill_agent.h
+++ b/components/autofill/content/renderer/autofill_agent.h
@@ -127,6 +127,17 @@ class AutofillAgent : public content::RenderFrameObserver,
void FocusedNodeChanged(const blink::WebNode& node) override;
void OnDestruct() override;
+ // Fires IPC messages for a given form submission. Will fire
+ // AutofillHostMsg_WillSubmitForm, AutofillHostMsg_FormSubmitted, or both,
+ // depending on the booleans given. Respects submitted_forms_ contents to
+ // ensure no duplicate submissions of AutofillHostMsg_WillSubmitForm.
+ void FireHostSubmitEvents(const blink::WebFormElement& form,
Mathieu 2016/05/25 17:48:55 it's good to have flexible functions, but in this
tmartino 2016/05/25 18:39:42 Done
+ bool willSubmitForm,
Mathieu 2016/05/25 17:48:55 nit:use_this_name_style
tmartino 2016/05/25 18:39:42 whoops_done
+ bool formSubmitted);
+ void FireHostSubmitEvents(const FormData& form_data,
+ bool willSubmitForm,
+ bool formSubmitted);
+
// Shuts the AutofillAgent down on RenderFrame deletion. Safe to call multiple
// times.
void Shutdown();

Powered by Google App Engine
This is Rietveld 408576698