First pass at refactoring autofill_agent to eventually incorporate Synthetic Form logic.

components/autofill/content/renderer/autofill_agent.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
 
 #include <set>
 #include <vector>
 
@@ skipping 109 matching lines @@
   bool OnMessageReceived(const IPC::Message& message) override;
   void DidCommitProvisionalLoad(bool is_new_navigation,
                                 bool is_same_page_navigation) override;
   void DidFinishDocumentLoad() override;
   void WillSendSubmitEvent(const blink::WebFormElement& form) override;
   void WillSubmitForm(const blink::WebFormElement& form) override;
   void DidChangeScrollOffset() override;
   void FocusedNodeChanged(const blink::WebNode& node) override;
   void OnDestruct() override;
 
+  // Fires IPC messages for a given form submission. Will fire
+  // AutofillHostMsg_WillSubmitForm, AutofillHostMsg_FormSubmitted, or both,
+  // depending on the booleans given. Respects submitted_forms_ contents to
+  // ensure no duplicate submissions of AutofillHostMsg_WillSubmitForm.
+  void FireHostSubmitEvents(const blink::WebFormElement& form,

[Mathieu, 2016/05/25 17:48:55]

it's good to have flexible functions, but in this case the second argument is
always true, so let's remove it?

[tmartino, 2016/05/25 18:39:42]

Done

+                            bool willSubmitForm,

[Mathieu, 2016/05/25 17:48:55]

nit:use_this_name_style

[tmartino, 2016/05/25 18:39:42]

whoops_done

+                            bool formSubmitted);
+  void FireHostSubmitEvents(const FormData& form_data,
+                            bool willSubmitForm,
+                            bool formSubmitted);
+
   // Shuts the AutofillAgent down on RenderFrame deletion. Safe to call multiple
   // times.
   void Shutdown();
 
   // Pass-through from LegacyAutofillAgent. This correlates with the
   // RenderViewObserver method.
   void FocusChangeComplete();
 
   // PageClickListener:
   void FormControlElementClicked(const blink::WebFormControlElement& element,
@@ skipping 145 matching lines @@
   mojom::AutofillDriverPtr mojo_autofill_driver_;
 
   base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_