Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3600)

Unified Diff: chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc

Issue 2012723002: Add separate UMA histograms for the account chooser with 1/many accounts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc
diff --git a/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc b/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc
index 5599335821f22eda382268ef5d3cb2fd39a01a51..7252fea07b076311a497e158e10f49f80020535a 100644
--- a/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc
+++ b/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc
@@ -121,6 +121,11 @@ TEST_F(PasswordDialogControllerTest, ShowAccountChooser) {
histogram_tester.ExpectUniqueSample(
"PasswordManager.AccountChooserDialog",
password_manager::metrics_util::ACCOUNT_CHOOSER_CREDENTIAL_CHOSEN, 1);
+ histogram_tester.ExpectUniqueSample(
+ "PasswordManager.AccountChooserDialogMultipleAccounts",
+ password_manager::metrics_util::ACCOUNT_CHOOSER_CREDENTIAL_CHOSEN, 1);
+ histogram_tester.ExpectTotalCount(
+ "PasswordManager.AccountChooserDialogOneAccount", 0);
}
TEST_F(PasswordDialogControllerTest, ShowAccountChooserAndSignIn) {
@@ -147,14 +152,21 @@ TEST_F(PasswordDialogControllerTest, ShowAccountChooserAndSignIn) {
histogram_tester.ExpectUniqueSample(
"PasswordManager.AccountChooserDialog",
password_manager::metrics_util::ACCOUNT_CHOOSER_SIGN_IN, 1);
+ histogram_tester.ExpectUniqueSample(
+ "PasswordManager.AccountChooserDialogOneAccount",
+ password_manager::metrics_util::ACCOUNT_CHOOSER_SIGN_IN, 1);
+ histogram_tester.ExpectTotalCount(
+ "PasswordManager.AccountChooserDialogMultipleAccounts", 0);
}
TEST_F(PasswordDialogControllerTest, AccountChooserClosed) {
base::HistogramTester histogram_tester;
StrictMock<MockPasswordPrompt> prompt;
+ std::vector<std::unique_ptr<autofill::PasswordForm>> locals;
+ locals.push_back(
+ base::WrapUnique(new autofill::PasswordForm(GetLocalForm())));
EXPECT_CALL(prompt, ShowAccountChooser());
- controller().ShowAccountChooser(&prompt,
- PasswordDialogController::FormsVector(),
+ controller().ShowAccountChooser(&prompt, std::move(locals),
PasswordDialogController::FormsVector());
EXPECT_CALL(ui_controller_mock(), OnDialogHidden());
@@ -162,6 +174,11 @@ TEST_F(PasswordDialogControllerTest, AccountChooserClosed) {
histogram_tester.ExpectUniqueSample(
"PasswordManager.AccountChooserDialog",
password_manager::metrics_util::ACCOUNT_CHOOSER_DISMISSED, 1);
+ histogram_tester.ExpectUniqueSample(
+ "PasswordManager.AccountChooserDialogOneAccount",
+ password_manager::metrics_util::ACCOUNT_CHOOSER_DISMISSED, 1);
+ histogram_tester.ExpectTotalCount(
+ "PasswordManager.AccountChooserDialogMultipleAccounts", 0);
}
TEST_F(PasswordDialogControllerTest, AutoSigninPromo) {

Powered by Google App Engine
This is Rietveld 408576698