Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8106)

Unified Diff: chrome/browser/ui/passwords/password_dialog_controller_impl.cc

Issue 2012723002: Add separate UMA histograms for the account chooser with 1/many accounts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/password_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/passwords/password_dialog_controller_impl.cc b/chrome/browser/ui/passwords/password_dialog_controller_impl.cc
index 6eb80c570bee2a571ff8645ded44a46faa44e2d0..45367bceaf1f6241c8154fbd7f4e3958299f643a 100644
--- a/chrome/browser/ui/passwords/password_dialog_controller_impl.cc
+++ b/chrome/browser/ui/passwords/password_dialog_controller_impl.cc
@@ -112,15 +112,20 @@ void PasswordDialogControllerImpl::OnSmartLockLinkClicked() {
void PasswordDialogControllerImpl::OnChooseCredentials(
const autofill::PasswordForm& password_form,
password_manager::CredentialType credential_type) {
- password_manager::metrics_util::LogAccountChooserUserAction(
- password_manager::metrics_util::ACCOUNT_CHOOSER_CREDENTIAL_CHOSEN);
+ if (local_credentials_.size() == 1) {
+ password_manager::metrics_util::LogAccountChooserUserActionOneAccount(
+ password_manager::metrics_util::ACCOUNT_CHOOSER_CREDENTIAL_CHOSEN);
+ } else {
+ password_manager::metrics_util::LogAccountChooserUserActionManyAccounts(
+ password_manager::metrics_util::ACCOUNT_CHOOSER_CREDENTIAL_CHOSEN);
+ }
ResetDialog();
delegate_->ChooseCredential(password_form, credential_type);
}
void PasswordDialogControllerImpl::OnSignInClicked() {
DCHECK_EQ(1u, local_credentials_.size());
- password_manager::metrics_util::LogAccountChooserUserAction(
+ password_manager::metrics_util::LogAccountChooserUserActionOneAccount(
password_manager::metrics_util::ACCOUNT_CHOOSER_SIGN_IN);
ResetDialog();
delegate_->ChooseCredential(
@@ -150,8 +155,13 @@ void PasswordDialogControllerImpl::OnAutoSigninTurnOff() {
void PasswordDialogControllerImpl::OnCloseDialog() {
if (account_chooser_dialog_) {
- password_manager::metrics_util::LogAccountChooserUserAction(
- password_manager::metrics_util::ACCOUNT_CHOOSER_DISMISSED);
+ if (local_credentials_.size() == 1) {
+ password_manager::metrics_util::LogAccountChooserUserActionOneAccount(
+ password_manager::metrics_util::ACCOUNT_CHOOSER_DISMISSED);
+ } else {
+ password_manager::metrics_util::LogAccountChooserUserActionManyAccounts(
+ password_manager::metrics_util::ACCOUNT_CHOOSER_DISMISSED);
+ }
account_chooser_dialog_ = nullptr;
}
if (autosignin_dialog_) {
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698