Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2012653003: [Signin] Upstream SigninTest. (Closed)

Created:
4 years, 6 months ago by maxbogue
Modified:
4 years, 6 months ago
Reviewers:
gogerald1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Signin] Upstream SigninTest. BUG=614776 Committed: https://crrev.com/ab02c4bd32a9ae8c53b9c9976b9793168d740670 Cr-Commit-Position: refs/heads/master@{#396177}

Patch Set 1 #

Patch Set 2 : Tweak comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+457 lines, -0 lines) Patch
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninTest.java View 1 1 chunk +456 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2009603005 Patch 1
Issue 2009603005 Patch 20001
Issue 2009603005 Patch 40001

Messages

Total messages: 12 (5 generated)
maxbogue
Ganggui, PTAL!
4 years, 6 months ago (2016-05-25 19:05:15 UTC) #2
gogerald1
LGTM
4 years, 6 months ago (2016-05-25 20:50:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012653003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012653003/20001
4 years, 6 months ago (2016-05-25 20:56:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/189915)
4 years, 6 months ago (2016-05-25 21:06:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012653003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012653003/20001
4 years, 6 months ago (2016-05-26 14:43:21 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-26 15:29:44 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 15:31:03 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ab02c4bd32a9ae8c53b9c9976b9793168d740670
Cr-Commit-Position: refs/heads/master@{#396177}

Powered by Google App Engine
This is Rietveld 408576698