[Sync] Clean up Android test code a bit.

[Sync] Clean up Android test code a bit.

- Remove SigninTestUtil.get() and make it a fully static class.
- Add SigninTestUtil.getCurrentAccount() for convenience.
- setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
  no such thing as signing in to sync.
- Remove SyncTestUtil.verify* and replace with asserts on SyncTestUtil.isSyncRequested
  and SigninTestUtil.getCurrentAccount.
- Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
  a flake related to signin state.

BUG=

Committed: https://crrev.com/0b76f4432df2571fd8883419153fc871a74567f3
Cr-Commit-Position: refs/heads/master@{#396648}

[maxbogue, 2016-05-25 19:48:07]

Description was changed from

==========
[Sync] Clean up Android test code a bit.

BUG=
==========

to

==========
[Sync] Clean up Android test code a bit.

- Remove SigninTestUtil.get() and make it a fully static class.
- Add SigninTestUtil.getCurrentAccount() for convenience.
- setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
  no such thing as signing in to sync.
- Remove SyncTestUtil.verify* and replace with asserts on
SyncTestUtil.isSyncRequested
  and SigninTestUtil.getCurrentAccount.
- Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
  a flake related to signin state.

BUG=
==========

[maxbogue, 2016-05-25 19:49:39]

maxbogue@chromium.org changed reviewers:
+ pavely@chromium.org

[maxbogue, 2016-05-25 19:49:40]

Pavel, PTAL. +Patrick FYI.

[pavely, 2016-05-25 22:34:30]

lgtm

[maxbogue, 2016-05-26 18:20:23]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-05-26 18:21:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009603005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009603005/40001

[commit-bot: I haz the power, 2016-05-26 18:29:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 18:29:32]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[maxbogue, 2016-05-26 20:17:02]

maxbogue@chromium.org changed reviewers:
+ nyquist@chromium.org

[maxbogue, 2016-05-26 20:17:03]

+Tommy for owners on all the non-sync stuff.

[nyquist, 2016-05-27 21:24:19]

rs lgtm

[maxbogue, 2016-05-28 21:57:11]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-05-28 21:57:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009603005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009603005/40001

[commit-bot: I haz the power, 2016-05-28 22:38:01]

Description was changed from

==========
[Sync] Clean up Android test code a bit.

- Remove SigninTestUtil.get() and make it a fully static class.
- Add SigninTestUtil.getCurrentAccount() for convenience.
- setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
  no such thing as signing in to sync.
- Remove SyncTestUtil.verify* and replace with asserts on
SyncTestUtil.isSyncRequested
  and SigninTestUtil.getCurrentAccount.
- Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
  a flake related to signin state.

BUG=
==========

to

==========
[Sync] Clean up Android test code a bit.

- Remove SigninTestUtil.get() and make it a fully static class.
- Add SigninTestUtil.getCurrentAccount() for convenience.
- setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
  no such thing as signing in to sync.
- Remove SyncTestUtil.verify* and replace with asserts on
SyncTestUtil.isSyncRequested
  and SigninTestUtil.getCurrentAccount.
- Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
  a flake related to signin state.

BUG=
==========

[commit-bot: I haz the power, 2016-05-28 22:38:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-28 22:39:57]

Description was changed from

==========
[Sync] Clean up Android test code a bit.

- Remove SigninTestUtil.get() and make it a fully static class.
- Add SigninTestUtil.getCurrentAccount() for convenience.
- setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
  no such thing as signing in to sync.
- Remove SyncTestUtil.verify* and replace with asserts on
SyncTestUtil.isSyncRequested
  and SigninTestUtil.getCurrentAccount.
- Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
  a flake related to signin state.

BUG=
==========

to

==========
[Sync] Clean up Android test code a bit.

- Remove SigninTestUtil.get() and make it a fully static class.
- Add SigninTestUtil.getCurrentAccount() for convenience.
- setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
  no such thing as signing in to sync.
- Remove SyncTestUtil.verify* and replace with asserts on
SyncTestUtil.isSyncRequested
  and SigninTestUtil.getCurrentAccount.
- Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
  a flake related to signin state.

BUG=

Committed: https://crrev.com/0b76f4432df2571fd8883419153fc871a74567f3
Cr-Commit-Position: refs/heads/master@{#396648}
==========

[commit-bot: I haz the power, 2016-05-28 22:39:59]

Patchset 3 (id:??) landed as
https://crrev.com/0b76f4432df2571fd8883419153fc871a74567f3
Cr-Commit-Position: refs/heads/master@{#396648}

[clamy, 2016-05-30 12:22:43]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2019363002/ by clamy@chromium.org.

The reason for reverting is: This is breaking compilation on the Android ToT
downstream bot, so reverting since this is an Android only patch (see
https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/cla...
).