Remove NTP dependency on //content/...

chrome/browser/android/ntp/most_visited_sites.h

Index: chrome/browser/android/ntp/most_visited_sites.h
diff --git a/chrome/browser/android/ntp/most_visited_sites.h b/chrome/browser/android/ntp/most_visited_sites.h
index 14b3e636a238272ea55742e40f5addd24c8b8455..d7451d3145548465a6628f3410cb8fe8fa366312 100644
--- a/chrome/browser/android/ntp/most_visited_sites.h
+++ b/chrome/browser/android/ntp/most_visited_sites.h
@@ -124,7 +124,8 @@ class MostVisitedSites : public history::TopSitesObserver,
     DISALLOW_COPY_AND_ASSIGN(Suggestion);
   };
 
-  MostVisitedSites(PrefService* prefs,
+  MostVisitedSites(scoped_refptr<base::SequencedWorkerPool> blocking_pool,

[Marc Treib, 2016/05/25 08:39:26]

It looks like you actually only need one TaskRunner, rather than a whole pool.
Would it be better to just pass in a TaskRunner? (Actual question - I'm not sure
what's better. One consequence would be that the shutdown behavior would be
defined outside of this class.)

[sfiera, 2016/05/25 08:44:44]

That's what I had initially, but bauerb asked to keep shutdown behavior and
blundell suggested the SWP here.

[blundell, 2016/05/25 09:00:24]

Yeah, I think that given that this class explicitly defines shutdown behavior,
it makes sense to keep that logic internal to the class.

+                   PrefService* prefs,
                    const TemplateURLService* template_url_service,
                    variations::VariationsService* variations_service,
                    net::URLRequestContextGetter* download_context,
@@ -271,6 +272,9 @@ class MostVisitedSites : public history::TopSitesObserver,
 
   SuggestionsVector current_suggestions_;
 
+  base::ThreadChecker thread_checker_;
+  scoped_refptr<base::SequencedWorkerPool> blocking_pool_;
+
   // For callbacks may be run after destruction.
   base::WeakPtrFactory<MostVisitedSites> weak_ptr_factory_;