Remove NTP dependency on //content/...

chrome/browser/android/ntp/most_visited_sites.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_NTP_MOST_VISITED_SITES_H_
 #define CHROME_BROWSER_ANDROID_NTP_MOST_VISITED_SITES_H_
 
 #include <stddef.h>
 
 #include <memory>
@@ skipping 106 matching lines @@
     Suggestion();
     ~Suggestion();
 
     Suggestion(Suggestion&&);
     Suggestion& operator=(Suggestion&&);
 
    private:
     DISALLOW_COPY_AND_ASSIGN(Suggestion);
   };
 
-  MostVisitedSites(PrefService* prefs,
+  MostVisitedSites(scoped_refptr<base::SequencedWorkerPool> blocking_pool,

[Marc Treib, 2016/05/25 08:39:26]

It looks like you actually only need one TaskRunner, rather than a whole pool.
Would it be better to just pass in a TaskRunner? (Actual question - I'm not sure
what's better. One consequence would be that the shutdown behavior would be
defined outside of this class.)

[sfiera, 2016/05/25 08:44:44]

That's what I had initially, but bauerb asked to keep shutdown behavior and
blundell suggested the SWP here.

[blundell, 2016/05/25 09:00:24]

Yeah, I think that given that this class explicitly defines shutdown behavior,
it makes sense to keep that logic internal to the class.

+                   PrefService* prefs,
                    const TemplateURLService* template_url_service,
                    variations::VariationsService* variations_service,
                    net::URLRequestContextGetter* download_context,
                    const base::FilePath& popular_sites_directory,
                    scoped_refptr<history::TopSites> top_sites,
                    suggestions::SuggestionsService* suggestions,
                    MostVisitedSitesSupervisor* supervisor);
 
   ~MostVisitedSites() override;
 
@@ skipping 126 matching lines @@
       suggestions_subscription_;
 
   ScopedObserver<history::TopSites, history::TopSitesObserver> scoped_observer_;
 
   MostVisitedSource mv_source_;
 
   std::unique_ptr<PopularSites> popular_sites_;
 
   SuggestionsVector current_suggestions_;
 
+  base::ThreadChecker thread_checker_;
+  scoped_refptr<base::SequencedWorkerPool> blocking_pool_;
+
   // For callbacks may be run after destruction.
   base::WeakPtrFactory<MostVisitedSites> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MostVisitedSites);
 };
 
 #endif  // CHROME_BROWSER_ANDROID_NTP_MOST_VISITED_SITES_H_