Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2012463002: Fix a crash in HttpVaryData::MatchesRequests. (Closed)

Created:
4 years, 7 months ago by gavinp
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fix a crash in HttpVaryData::MatchesRequests. crbug.com/469675 remove an implicit Vary: Cookie for redirected requests. But some cached redirected requests could still have HttpVaryData::is_valid_ == true. Therefore some requests could reach a NOTREACHED() in HttpVaryData::MatchesRequests() because comparing an HTTP request vary that have a HttpVaryData::Init() now returning false because no Vary from the request with a previously cached HttpVaryRequest that have is_valid_ == true. BUG=611575 Review-Url: https://codereview.chromium.org/2000123002 Cr-Commit-Position: refs/heads/master@{#395317} (cherry picked from commit 7ec544a858f4dd2b5b3a0ad0949a1f24f55f10b4) Committed: https://chromium.googlesource.com/chromium/src/+/ac453e0ec84fd9f1c87bf06080eca3a586f32bee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M net/http/http_vary_data.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
gavinp
4 years, 7 months ago (2016-05-24 14:29:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ac453e0ec84fd9f1c87bf06080eca3a586f32bee.

Powered by Google App Engine
This is Rietveld 408576698