Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: net/http/http_vary_data.cc

Issue 2012463002: Fix a crash in HttpVaryData::MatchesRequests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_vary_data.cc
diff --git a/net/http/http_vary_data.cc b/net/http/http_vary_data.cc
index a8faf56ffdfb03d8578928597e2471828c0691cb..3e81fc96f5208544e1abbbb3866416494984cb7a 100644
--- a/net/http/http_vary_data.cc
+++ b/net/http/http_vary_data.cc
@@ -68,9 +68,8 @@ bool HttpVaryData::MatchesRequest(
const HttpResponseHeaders& cached_response_headers) const {
HttpVaryData new_vary_data;
if (!new_vary_data.Init(request_info, cached_response_headers)) {
- // This shouldn't happen provided the same response headers passed here
- // were also used when initializing |this|.
- NOTREACHED();
+ // This case can happen if |this| was loaded from a cache that was populated
+ // by a build before crbug.com/469675 was fixed.
return false;
}
return memcmp(&new_vary_data.request_digest_, &request_digest_,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698