Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2012353002: Add CECPQ1 ciphers to the cipher suites table. (Closed)

Created:
4 years, 6 months ago by agl
Modified:
4 years, 6 months ago
Reviewers:
mab1, mab
CC:
chromium-reviews, cbentzel+watch_chromium.org, davidben
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CECPQ1 ciphers to the cipher suites table. These cipher suites are experimental and non-standard. This change adds them to the cipher suite table so that Chromium can recognise them and registers them as modern and acceptable for HTTP/2. BUG=none Committed: https://crrev.com/42720529663bed3eedce8b100d3a5aae9bcca6a3 Cr-Commit-Position: refs/heads/master@{#396344}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing mab's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M net/ssl/ssl_cipher_suite_names.cc View 5 chunks +11 lines, -1 line 0 comments Download
M net/ssl/ssl_cipher_suite_names_unittest.cc View 1 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
agl
4 years, 6 months ago (2016-05-26 20:45:31 UTC) #2
mab
lgtm https://codereview.chromium.org/2012353002/diff/1/net/ssl/ssl_cipher_suite_names_unittest.cc File net/ssl/ssl_cipher_suite_names_unittest.cc (right): https://codereview.chromium.org/2012353002/diff/1/net/ssl/ssl_cipher_suite_names_unittest.cc#newcode144 net/ssl/ssl_cipher_suite_names_unittest.cc:144: 0x16ba}; Using a loop seems inconsistent with the ...
4 years, 6 months ago (2016-05-26 21:14:58 UTC) #4
agl
https://codereview.chromium.org/2012353002/diff/1/net/ssl/ssl_cipher_suite_names_unittest.cc File net/ssl/ssl_cipher_suite_names_unittest.cc (right): https://codereview.chromium.org/2012353002/diff/1/net/ssl/ssl_cipher_suite_names_unittest.cc#newcode144 net/ssl/ssl_cipher_suite_names_unittest.cc:144: 0x16ba}; On 2016/05/26 21:14:57, mab wrote: > Using a ...
4 years, 6 months ago (2016-05-26 23:26:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012353002/20001
4 years, 6 months ago (2016-05-26 23:27:32 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 01:20:43 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 01:23:04 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/42720529663bed3eedce8b100d3a5aae9bcca6a3
Cr-Commit-Position: refs/heads/master@{#396344}

Powered by Google App Engine
This is Rietveld 408576698