Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1490)

Unified Diff: runtime/vm/service.cc

Issue 201213004: Use VM tag in profile and add stack trace trie (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/profiler.cc ('K') | « runtime/vm/profiler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 1903e4ba01f2e05987a094fc62aabccc950988f2..583b79f0192a4077e0d84d07d910e454f46519e7 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -1310,7 +1310,12 @@ static bool HandleProfile(Isolate* isolate, JSONStream* js) {
// A full profile includes disassembly of all Dart code objects.
// TODO(johnmccutchan): Add sub command to trigger full code dump.
bool full_profile = false;
- Profiler::PrintToJSONStream(isolate, js, full_profile);
+ const char* tags_option = js->LookupOption("tags");
+ bool use_tags = true;
+ if ((tags_option != NULL) && (strcmp("hide", tags_option) == 0)) {
+ use_tags = false;
+ }
turnidge 2014/03/17 21:19:31 Does it make sense to do any unit testing of this
Cutch 2014/03/18 14:39:19 Added a unit test for the profile command and an e
+ Profiler::PrintToJSONStream(isolate, js, full_profile, use_tags);
return true;
}
« runtime/vm/profiler.cc ('K') | « runtime/vm/profiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698