Use VM tag in profile and add stack trace trie

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 
 #include "vm/compiler.h"
 #include "vm/coverage.h"
@@ skipping 1292 matching lines @@
   }
   PrintError(js, "Could not find code with id: %s", command);
   return true;
 }
 
 
 static bool HandleProfile(Isolate* isolate, JSONStream* js) {
   // A full profile includes disassembly of all Dart code objects.
   // TODO(johnmccutchan): Add sub command to trigger full code dump.
   bool full_profile = false;
-  Profiler::PrintToJSONStream(isolate, js, full_profile);
+  const char* tags_option = js->LookupOption("tags");
+  bool use_tags = true;
+  if ((tags_option != NULL) && (strcmp("hide", tags_option) == 0)) {
+    use_tags = false;
+  }

[turnidge, 2014/03/17 21:19:31]

Does it make sense to do any unit testing of this part of the change?

Are you sure you want to accept weird values of "tags" here?  (like
tags=jfdkljkldfjlsd)

[Cutch, 2014/03/18 14:39:19]

Added a unit test for the profile command and an error case when the tags option
value isn't "hide".

+  Profiler::PrintToJSONStream(isolate, js, full_profile, use_tags);
   return true;
 }
 
 static bool HandleCoverage(Isolate* isolate, JSONStream* js) {
   CodeCoverage::PrintToJSONStream(isolate, js);
   return true;
 }
 
 
 static bool HandleAllocationProfile(Isolate* isolate, JSONStream* js) {
@@ skipping 258 matching lines @@
   while (current != NULL) {
     if (strcmp(name, current->name()) == 0) {
       return current;
     }
     current = current->next();
   }
   return NULL;
 }
 
 }  // namespace dart