Source/platform/DragImage.cpp - Issue 201213002: Remove uses of SkBitmap::Config (deprecated) from core/ and platform/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/DragImage.cpp

Issue 201213002: Remove uses of SkBitmap::Config (deprecated) from core/ and platform/. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/ImageBitmapTest.cpp ('K') | « Source/core/frame/ImageBitmapTest.cpp ('k') | Source/platform/graphics/DeferredImageDecoderTest.cpp » ('j') | Source/platform/graphics/GraphicsContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/DragImage.cpp

diff --git a/Source/platform/DragImage.cpp b/Source/platform/DragImage.cpp

index 7bc1b92dd4284cb5b45f187aef8620792865c2ce..c075a9221b75b0e142b684005e1ee1f640b6ecfe 100644

--- a/Source/platform/DragImage.cpp

+++ b/Source/platform/DragImage.cpp

@@ -89,9 +89,7 @@ PassOwnPtr<DragImage> DragImage::create(Image* image, RespectImageOrientationEnu

destRect = destRect.transposedRect();

SkBitmap skBitmap;

- skBitmap.setConfig(

- SkBitmap::kARGB_8888_Config, sizeRespectingOrientation.width(), sizeRespectingOrientation.height());

- if (!skBitmap.allocPixels())

+ if (!skBitmap.allocN32Pixels(sizeRespectingOrientation.width(), sizeRespectingOrientation.height()))

return nullptr;

SkCanvas canvas(skBitmap);