Source/core/frame/ImageBitmapTest.cpp - Issue 201213002: Remove uses of SkBitmap::Config (deprecated) from core/ and platform/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/ImageBitmapTest.cpp

Issue 201213002: Remove uses of SkBitmap::Config (deprecated) from core/ and platform/. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/ImageBitmapTest.cpp

diff --git a/Source/core/frame/ImageBitmapTest.cpp b/Source/core/frame/ImageBitmapTest.cpp

index d6981bcbfdbaf4463461790257747b108896022a..d4633c8142f45636ce054da1ef7ab7d69bbb79b5 100644

--- a/Source/core/frame/ImageBitmapTest.cpp

+++ b/Source/core/frame/ImageBitmapTest.cpp

@@ -54,12 +54,10 @@ class ImageBitmapTest : public ::testing::Test {

protected:

virtual void SetUp()

{

- m_bitmap.setConfig(SkBitmap::kARGB_8888_Config, 10, 10);

- m_bitmap.allocPixels();

+ ASSERT_TRUE(m_bitmap.allocN32Pixels(10, 10));

reed1 2014/03/17 17:36:51 I presume ASSERT_TRUE executes its argument in deb

m_bitmap.eraseColor(0xFFFFFFFF);

- m_bitmap2.setConfig(SkBitmap::kARGB_8888_Config, 5, 5);

- m_bitmap2.allocPixels();

+ ASSERT_TRUE(m_bitmap2.allocN32Pixels(5, 5));

m_bitmap2.eraseColor(0xAAAAAAAA);

// Save the global memory cache to restore it upon teardown.

« no previous file with comments | « no previous file | Source/platform/DragImage.cpp » ('j') | Source/platform/graphics/GraphicsContext.cpp » ('J')