Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2011983003: DevTools: fix crash upon non-initialized IdentifiersFactory (Closed)

Created:
4 years, 7 months ago by caseq
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix crash upon non-initialized IdentifiersFactory Originally regressed here: https://codereview.chromium.org/1838523004 BUG=612282 Committed: https://crrev.com/ef7aca16ba536b6e3b4d4ca2c7d60ef547f44267 Cr-Commit-Position: refs/heads/master@{#396113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M third_party/WebKit/Source/core/inspector/IdentifiersFactory.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
caseq
4 years, 7 months ago (2016-05-25 23:25:39 UTC) #2
dgozman
lgtm
4 years, 7 months ago (2016-05-25 23:38:54 UTC) #3
dgozman
lgtm lgtm
4 years, 7 months ago (2016-05-25 23:38:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011983003/1
4 years, 7 months ago (2016-05-25 23:40:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 04:04:50 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 04:06:01 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ef7aca16ba536b6e3b4d4ca2c7d60ef547f44267
Cr-Commit-Position: refs/heads/master@{#396113}

Powered by Google App Engine
This is Rietveld 408576698