Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: components/network_session_configurator/network_session_configurator.cc

Issue 2011983002: Remove |parse_alternative_service| flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_session_configurator/network_session_configurator.cc
diff --git a/components/network_session_configurator/network_session_configurator.cc b/components/network_session_configurator/network_session_configurator.cc
index 4e344e4fd3ab2ceeeff750f9d89cefdf4aeb5011..f2736932faec635a0c188c84286a6e8b51ca6d47 100644
--- a/components/network_session_configurator/network_session_configurator.cc
+++ b/components/network_session_configurator/network_session_configurator.cc
@@ -45,20 +45,6 @@ const char kSpdyFieldTrialSpdy31GroupNamePrefix[] = "Spdy31Enabled";
const char kSpdyFieldTrialSpdy4GroupNamePrefix[] = "Spdy4Enabled";
const char kSpdyFieldTrialParametrizedPrefix[] = "Parametrized";
-// The AltSvc trial controls whether Alt-Svc headers are parsed.
-// Disabled:
-// Alt-Svc headers are not parsed.
-// Alternate-Protocol headers are parsed.
-// Enabled:
-// Alt-Svc headers are parsed, but only same-host entries are used by
-// default. (Use "enable_alternative_service_with_different_host" QUIC
-// parameter to enable entries with different hosts.)
-// Alternate-Protocol headers are ignored for responses that have an Alt-Svc
-// header.
-const char kAltSvcFieldTrialName[] = "ParseAltSvc";
-const char kAltSvcFieldTrialDisabledPrefix[] = "AltSvcDisabled";
-const char kAltSvcFieldTrialEnabledPrefix[] = "AltSvcEnabled";
-
// Field trial for NPN.
const char kNpnTrialName[] = "NPN";
const char kNpnTrialEnabledGroupNamePrefix[] = "Enable";
@@ -154,18 +140,6 @@ void ConfigureSpdyParams(const base::CommandLine& command_line,
}
}
-void ConfigureAltSvcParams(const base::CommandLine& command_line,
- base::StringPiece altsvc_trial_group,
- net::HttpNetworkSession::Params* params) {
- if (altsvc_trial_group.starts_with(kAltSvcFieldTrialEnabledPrefix)) {
- params->parse_alternative_services = true;
- return;
- }
- if (altsvc_trial_group.starts_with(kAltSvcFieldTrialDisabledPrefix)) {
- params->parse_alternative_services = false;
- }
-}
-
void ConfigureNPNParams(const base::CommandLine& command_line,
base::StringPiece npn_trial_group,
net::HttpNetworkSession::Params* params) {
@@ -547,10 +521,6 @@ void ParseFieldTrialsAndCommandLineInternal(
// The command line flags will be associated with a group that is reported so
// long as trial is actually queried.
- std::string altsvc_trial_group =
- base::FieldTrialList::FindFullName(kAltSvcFieldTrialName);
- ConfigureAltSvcParams(command_line, altsvc_trial_group, params);
-
std::string quic_trial_group =
base::FieldTrialList::FindFullName(kQuicFieldTrialName);
VariationParameters quic_trial_params;

Powered by Google App Engine
This is Rietveld 408576698