Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2011983002: Remove |parse_alternative_service| flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_session_configurator/network_session_configurator_unittest.cc
diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc
index 4156c50dd9369d22a497f198cf93ff0827822b3f..c1e5fdfc72af388cd23dab7bd40fcef51d65e638 100644
--- a/components/network_session_configurator/network_session_configurator_unittest.cc
+++ b/components/network_session_configurator/network_session_configurator_unittest.cc
@@ -57,7 +57,6 @@ TEST_F(NetworkSessionConfiguratorTest, Defaults) {
EXPECT_FALSE(params_.enable_spdy31);
EXPECT_TRUE(params_.enable_http2);
EXPECT_FALSE(params_.enable_tcp_fast_open_for_ssl);
- EXPECT_TRUE(params_.parse_alternative_services);
EXPECT_TRUE(params_.enable_alternative_service_with_different_host);
EXPECT_FALSE(params_.enable_npn);
EXPECT_TRUE(params_.enable_priority_dependencies);
@@ -85,24 +84,6 @@ TEST_F(NetworkSessionConfiguratorTest, TestingFixedPort) {
EXPECT_EQ(1234u, params_.testing_fixed_https_port);
}
-TEST_F(NetworkSessionConfiguratorTest, AltSvcFieldTrialEnabled) {
- base::FieldTrialList::CreateFieldTrial("ParseAltSvc", "AltSvcEnabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.parse_alternative_services);
- EXPECT_TRUE(params_.enable_alternative_service_with_different_host);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, AltSvcFieldTrialDisabled) {
- base::FieldTrialList::CreateFieldTrial("ParseAltSvc", "AltSvcDisabled");
-
- ParseFieldTrials();
-
- EXPECT_FALSE(params_.parse_alternative_services);
- EXPECT_TRUE(params_.enable_alternative_service_with_different_host);
-}
-
TEST_F(NetworkSessionConfiguratorTest, SpdyFieldTrialHoldbackEnabled) {
net::HttpStreamFactory::set_spdy_enabled(true);
base::FieldTrialList::CreateFieldTrial("SPDY", "SpdyDisabled");
@@ -214,7 +195,6 @@ TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) {
EXPECT_FALSE(params_.quic_enable_non_blocking_io);
EXPECT_FALSE(params_.quic_disable_disk_cache);
EXPECT_FALSE(params_.quic_prefer_aes);
- EXPECT_TRUE(params_.parse_alternative_services);
EXPECT_TRUE(params_.enable_alternative_service_with_different_host);
EXPECT_EQ(0, params_.quic_max_number_of_lossy_connections);
EXPECT_EQ(1.0f, params_.quic_packet_loss_threshold);
@@ -279,7 +259,6 @@ TEST_F(NetworkSessionConfiguratorTest,
ParseFieldTrialsAndCommandLine();
EXPECT_FALSE(params_.enable_quic);
- EXPECT_TRUE(params_.parse_alternative_services);
EXPECT_TRUE(params_.enable_alternative_service_with_different_host);
}
@@ -292,7 +271,6 @@ TEST_F(NetworkSessionConfiguratorTest,
ParseFieldTrialsAndCommandLine();
EXPECT_TRUE(params_.enable_quic);
- EXPECT_TRUE(params_.parse_alternative_services);
EXPECT_TRUE(params_.enable_alternative_service_with_different_host);
}
@@ -524,8 +502,6 @@ TEST_F(NetworkSessionConfiguratorTest,
ParseFieldTrials();
EXPECT_TRUE(params_.enable_alternative_service_with_different_host);
- // QUIC AltSvc pooling parameter should also enable AltSvc parsing.
- EXPECT_TRUE(params_.parse_alternative_services);
}
TEST_F(NetworkSessionConfiguratorTest,
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | ios/crnet/crnet_environment.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698