Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1338)

Issue 2011983002: Remove |parse_alternative_service| flag. (Closed)

Created:
4 years, 6 months ago by Bence
Modified:
4 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove |parse_alternative_service| flag. |parse_alternative_service| is already true by default both in production and in tests. * Remove flag from HttpNetworkSession::Params and SpdySessionDependencies. * Remove "ParseAltSvc" field trial. * Remove Alternate-Protocol parsing code. * Remove tests testing Alternate-Protocol that had Alt-Svc counterparts. * Change tests to test Alt-Svc if no such test existed yet. BUG=581331 Committed: https://crrev.com/1c196c6efdb9bc2da847ce195f9c9636955e45b2 Cr-Commit-Position: refs/heads/master@{#396643}

Patch Set 1 #

Patch Set 2 : Cronet change. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -726 lines) Patch
M components/cronet/ios/cronet_environment.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/network_session_configurator/network_session_configurator.cc View 1 2 3 chunks +0 lines, -30 lines 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 1 2 6 chunks +0 lines, -24 lines 0 comments Download
M ios/crnet/crnet_environment.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M jingle/glue/proxy_resolving_client_socket.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/bidirectional_stream_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_network_session.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 2 37 chunks +38 lines, -323 lines 0 comments Download
M net/http/http_server_properties.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_server_properties.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_stream_factory.h View 1 chunk +0 lines, -12 lines 0 comments Download
M net/http/http_stream_factory.cc View 3 chunks +20 lines, -109 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/log/net_log_util.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 5 chunks +4 lines, -204 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Bence
mef: PTAL at components/cronet and ios/crnet. Ryan: PTAL at components/network_session_configurator and net/. bengr: PTAL at ...
4 years, 6 months ago (2016-05-25 22:10:50 UTC) #2
Ryan Hamilton
lgtm
4 years, 6 months ago (2016-05-25 22:31:05 UTC) #3
Nicolas Zea
jingle LGTM
4 years, 6 months ago (2016-05-26 18:22:02 UTC) #4
bengr
data_reduction_proxy lgtm
4 years, 6 months ago (2016-05-27 19:50:30 UTC) #5
Bence
mef: ping.
4 years, 6 months ago (2016-05-27 20:01:16 UTC) #6
mef
cr[o]net lgtm
4 years, 6 months ago (2016-05-27 21:14:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011983002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011983002/40001
4 years, 6 months ago (2016-05-28 12:29:58 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-28 13:52:09 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-28 13:53:25 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1c196c6efdb9bc2da847ce195f9c9636955e45b2
Cr-Commit-Position: refs/heads/master@{#396643}

Powered by Google App Engine
This is Rietveld 408576698