Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2011913002: Revert of PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle (Closed)

Created:
4 years, 7 months ago by Michael van Ouwerkerk
Modified:
4 years, 7 months ago
CC:
chromium-reviews, davidben+watch_chromium.org, cbentzel+watch_chromium.org, romax+watch_chromium.org, tburkard+watch_chromium.org, fgorski+watch_chromium.org, petewil+watch_chromium.org, dewittj+watch_chromium.org, gavinp+prer_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle (patchset #22 id:420001 of https://codereview.chromium.org/1968593002/ ) Reason for revert: The unit tests are failing on asan-clang-phone, I'm sorry. https://bugs.chromium.org/p/chromium/issues/detail?id=614699 Original issue's description: > PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle and make it unit-testable. > > It proved challenging to write unittests wrt mocking PrerenderManager and/or PrerenderHandler and be able to create a stub PrerenderHandler without touching the prerender stack code so this CL takes the approach of adding an adapter between the Loader and prerender stack calls so that they can be intercepted for testing. > > BTW, PrerenderingLoader is actually the "BackgroundLoader" of go/chrome-background-loading > > BUG=601173 > > Committed: https://crrev.com/8ed74fd7c401a1ff9a5a57c270409e0f66f6d3ce > Cr-Commit-Position: refs/heads/master@{#395485} TBR=fgorski@chromium.org,pasko@chromium.org,petewil@chromium.org,gabadie@chromium.org,dougarnett@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=601173 Committed: https://crrev.com/9c983d12e207d07c7cb0922eccc102e6c7475f31 Cr-Commit-Position: refs/heads/master@{#395882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -787 lines) Patch
D chrome/browser/android/offline_pages/prerender_adapter.h View 1 chunk +0 lines, -106 lines 0 comments Download
D chrome/browser/android/offline_pages/prerender_adapter.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M chrome/browser/android/offline_pages/prerendering_loader.h View 2 chunks +8 lines, -81 lines 0 comments Download
M chrome/browser/android/offline_pages/prerendering_loader.cc View 1 chunk +9 lines, -150 lines 0 comments Download
D chrome/browser/android/offline_pages/prerendering_loader_unittest.cc View 1 chunk +0 lines, -288 lines 0 comments Download
M chrome/browser/android/offline_pages/prerendering_offliner.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/offline_pages/prerendering_offliner.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc View 5 chunks +9 lines, -18 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/offline_pages/background/offliner.h View 1 chunk +8 lines, -9 lines 0 comments Download
M components/offline_pages/background/request_coordinator.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M components/offline_pages/background/request_coordinator_unittest.cc View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael van Ouwerkerk
Created Revert of PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle
4 years, 7 months ago (2016-05-25 13:02:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011913002/1
4 years, 7 months ago (2016-05-25 13:02:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011913002/1
4 years, 7 months ago (2016-05-25 13:31:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 13:50:05 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 13:51:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c983d12e207d07c7cb0922eccc102e6c7475f31
Cr-Commit-Position: refs/heads/master@{#395882}

Powered by Google App Engine
This is Rietveld 408576698