Chromium Code Reviews
DescriptionRevert of PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle (patchset #22 id:420001 of https://codereview.chromium.org/1968593002/ )
Reason for revert:
The unit tests are failing on asan-clang-phone, I'm sorry.
https://bugs.chromium.org/p/chromium/issues/detail?id=614699
Original issue's description:
> PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle and make it unit-testable.
>
> It proved challenging to write unittests wrt mocking PrerenderManager and/or PrerenderHandler and be able to create a stub PrerenderHandler without touching the prerender stack code so this CL takes the approach of adding an adapter between the Loader and prerender stack calls so that they can be intercepted for testing.
>
> BTW, PrerenderingLoader is actually the "BackgroundLoader" of go/chrome-background-loading
>
> BUG=601173
>
> Committed: https://crrev.com/8ed74fd7c401a1ff9a5a57c270409e0f66f6d3ce
> Cr-Commit-Position: refs/heads/master@{#395485}
TBR=fgorski@chromium.org,pasko@chromium.org,petewil@chromium.org,gabadie@chromium.org,dougarnett@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=601173
Committed: https://crrev.com/9c983d12e207d07c7cb0922eccc102e6c7475f31
Cr-Commit-Position: refs/heads/master@{#395882}
Patch Set 1 #Messages
Total messages: 7 (2 generated)
|