Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

Issue 2011913002: Revert of PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/prerendering_offliner.h" 5 #include "chrome/browser/android/offline_pages/prerendering_offliner.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "chrome/browser/android/offline_pages/prerendering_loader.h" 10 #include "chrome/browser/android/offline_pages/prerendering_loader.h"
11 #include "components/offline_pages/background/offliner.h" 11 #include "components/offline_pages/background/offliner.h"
12 #include "components/offline_pages/background/save_page_request.h" 12 #include "components/offline_pages/background/save_page_request.h"
13 #include "content/public/test/test_browser_thread_bundle.h"
14 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
15 14
16 namespace offline_pages { 15 namespace offline_pages {
17 16
18 namespace { 17 namespace {
19 const int64_t kRequestId = 7; 18 const int64_t kRequestId = 7;
20 const GURL kHttpUrl("http://tunafish.com"); 19 const GURL kHttpUrl("http://tunafish.com");
21 const GURL kFileUrl("file://sailfish.png"); 20 const GURL kFileUrl("file://sailfish.png");
22 const ClientId kClientId("AsyncLoading", "88"); 21 const ClientId kClientId("AsyncLoading", "88");
23 22
24 // Mock Loader for testing the Offliner calls. 23 // Mock Loader for testing the Offliner calls.
25 class MockPrerenderingLoader : public PrerenderingLoader { 24 class MockPrerenderingLoader : public PrerenderingLoader {
26 public: 25 public:
27 explicit MockPrerenderingLoader(content::BrowserContext* browser_context) 26 explicit MockPrerenderingLoader(content::BrowserContext* browser_context)
28 : PrerenderingLoader(browser_context), 27 : PrerenderingLoader(browser_context), mock_loading_(false) {}
29 mock_loading_(false),
30 mock_loaded_(false) {}
31 ~MockPrerenderingLoader() override {} 28 ~MockPrerenderingLoader() override {}
32 29
33 bool LoadPage(const GURL& url, const LoadPageCallback& callback) override { 30 bool LoadPage(const GURL& url, const LoadPageCallback& callback) override {
34 mock_loading_ = true; 31 mock_loading_ = true;
35 return mock_loading_; 32 return mock_loading_;
36 } 33 }
37 34
38 void StopLoading() override { 35 void StopLoading() override { mock_loading_ = false; }
39 mock_loading_ = false;
40 mock_loaded_ = false;
41 }
42 bool IsIdle() override { return !mock_loading_ && !mock_loaded_; }
43 bool IsLoaded() override { return mock_loaded_; }
44 36
45 bool mock_loading() const { return mock_loading_; } 37 bool mock_loading() const { return mock_loading_; }
46 38
47 private: 39 private:
48 bool mock_loading_; 40 bool mock_loading_;
49 bool mock_loaded_;
50 41
51 DISALLOW_COPY_AND_ASSIGN(MockPrerenderingLoader); 42 DISALLOW_COPY_AND_ASSIGN(MockPrerenderingLoader);
52 }; 43 };
53 44
54 } // namespace 45 } // namespace
55 46
56 class PrerenderingOfflinerTest : public testing::Test { 47 class PrerenderingOfflinerTest : public testing::Test {
57 public: 48 public:
58 PrerenderingOfflinerTest(); 49 PrerenderingOfflinerTest();
59 ~PrerenderingOfflinerTest() override; 50 ~PrerenderingOfflinerTest() override;
60 51
61 void SetUp() override; 52 void SetUp() override;
62 53
63 PrerenderingOffliner* offliner() const { return offliner_.get(); } 54 PrerenderingOffliner* offliner() const { return offliner_.get(); }
64 Offliner::CompletionCallback const callback() { 55 Offliner::CompletionCallback const callback() {
65 return base::Bind(&PrerenderingOfflinerTest::OnCompletion, 56 return base::Bind(&PrerenderingOfflinerTest::OnCompletion,
66 base::Unretained(this)); 57 base::Unretained(this));
67 } 58 }
68 59
69 bool loading() const { return loader_->mock_loading(); } 60 bool loading() const { return loader_->mock_loading(); }
70 Offliner::RequestStatus completion_status() { return completion_status_; } 61 Offliner::CompletionStatus completion_status() {
62 return completion_status_;
63 }
71 64
72 private: 65 private:
73 void OnCompletion(const SavePageRequest& request, 66 void OnCompletion(const SavePageRequest& request,
74 Offliner::RequestStatus status); 67 Offliner::CompletionStatus status);
75 68
76 content::TestBrowserThreadBundle thread_bundle_;
77 std::unique_ptr<PrerenderingOffliner> offliner_; 69 std::unique_ptr<PrerenderingOffliner> offliner_;
78 // Not owned. 70 // Not owned.
79 MockPrerenderingLoader* loader_; 71 MockPrerenderingLoader* loader_;
80 Offliner::RequestStatus completion_status_; 72 Offliner::CompletionStatus completion_status_;
81 73
82 DISALLOW_COPY_AND_ASSIGN(PrerenderingOfflinerTest); 74 DISALLOW_COPY_AND_ASSIGN(PrerenderingOfflinerTest);
83 }; 75 };
84 76
85 PrerenderingOfflinerTest::PrerenderingOfflinerTest() 77 PrerenderingOfflinerTest::PrerenderingOfflinerTest() {}
86 : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {}
87 78
88 PrerenderingOfflinerTest::~PrerenderingOfflinerTest() {} 79 PrerenderingOfflinerTest::~PrerenderingOfflinerTest() {}
89 80
90 void PrerenderingOfflinerTest::SetUp() { 81 void PrerenderingOfflinerTest::SetUp() {
91 offliner_.reset(new PrerenderingOffliner(nullptr, nullptr, nullptr)); 82 offliner_.reset(new PrerenderingOffliner(nullptr, nullptr, nullptr));
92 std::unique_ptr<MockPrerenderingLoader> mock_loader( 83 std::unique_ptr<MockPrerenderingLoader> mock_loader(
93 new MockPrerenderingLoader(nullptr)); 84 new MockPrerenderingLoader(nullptr));
94 loader_ = mock_loader.get(); 85 loader_ = mock_loader.get();
95 offliner_->SetLoaderForTesting(std::move(mock_loader)); 86 offliner_->SetLoaderForTesting(std::move(mock_loader));
96 } 87 }
97 88
98 void PrerenderingOfflinerTest::OnCompletion(const SavePageRequest& request, 89 void PrerenderingOfflinerTest::OnCompletion(const SavePageRequest& request,
99 Offliner::RequestStatus status) { 90 Offliner::CompletionStatus status) {
100 completion_status_ = status; 91 completion_status_ = status;
101 } 92 }
102 93
103 // Tests initiate loading. 94 // Tests initiate loading.
104 TEST_F(PrerenderingOfflinerTest, LoadAndSaveBadUrl) { 95 TEST_F(PrerenderingOfflinerTest, LoadAndSaveBadUrl) {
105 base::Time creation_time = base::Time::Now(); 96 base::Time creation_time = base::Time::Now();
106 SavePageRequest request(kRequestId, kFileUrl, kClientId, creation_time); 97 SavePageRequest request(kRequestId, kFileUrl, kClientId, creation_time);
107 EXPECT_FALSE(offliner()->LoadAndSave(request, callback())); 98 EXPECT_FALSE(offliner()->LoadAndSave(request, callback()));
108 EXPECT_FALSE(loading()); 99 EXPECT_FALSE(loading());
109 } 100 }
(...skipping 11 matching lines...) Expand all
121 base::Time creation_time = base::Time::Now(); 112 base::Time creation_time = base::Time::Now();
122 SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time); 113 SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time);
123 EXPECT_TRUE(offliner()->LoadAndSave(request, callback())); 114 EXPECT_TRUE(offliner()->LoadAndSave(request, callback()));
124 EXPECT_TRUE(loading()); 115 EXPECT_TRUE(loading());
125 116
126 offliner()->Cancel(); 117 offliner()->Cancel();
127 EXPECT_FALSE(loading()); 118 EXPECT_FALSE(loading());
128 } 119 }
129 120
130 } // namespace offline_pages 121 } // namespace offline_pages
OLDNEW
« no previous file with comments | « chrome/browser/android/offline_pages/prerendering_offliner.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698