Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2011673002: [DevTools] Add notifyPopupOpeningObservers call before running debug loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
index 0f735f6046d6c9439c8f1294b71bc2eb515587ef..0adcd355a581578347ebd40567a2ffc7be96d642 100644
--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
@@ -196,6 +196,7 @@ private:
m_frozenViews.add(view);
views.append(view);
view->setIgnoreInputEvents(true);
+ view->chromeClient().notifyPopupOpeningObservers();
}
const WebFrameWidgetsSet& widgetImpls = WebFrameWidgetImpl::allInstances();
@@ -205,6 +206,7 @@ private:
m_frozenWidgets.add(widget);
widgets.append(widget);
widget->setIgnoreInputEvents(true);
+ widget->chromeClient().notifyPopupOpeningObservers();
dgozman 2016/05/26 19:27:29 We don't need this.
kozy 2016/05/26 19:38:02 Done.
}
// 2. Notify embedder about pausing.
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/WebFrameWidgetImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698