Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2011673002: [DevTools] Add notifyPopupOpeningObservers call before running debug loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 HeapVector<Member<WebFrameWidgetImpl>> widgets; 189 HeapVector<Member<WebFrameWidgetImpl>> widgets;
190 190
191 // 1. Disable input events. 191 // 1. Disable input events.
192 const HashSet<WebViewImpl*>& viewImpls = WebViewImpl::allInstances(); 192 const HashSet<WebViewImpl*>& viewImpls = WebViewImpl::allInstances();
193 HashSet<WebViewImpl*>::const_iterator viewImplsEnd = viewImpls.end(); 193 HashSet<WebViewImpl*>::const_iterator viewImplsEnd = viewImpls.end();
194 for (HashSet<WebViewImpl*>::const_iterator it = viewImpls.begin(); it ! = viewImplsEnd; ++it) { 194 for (HashSet<WebViewImpl*>::const_iterator it = viewImpls.begin(); it ! = viewImplsEnd; ++it) {
195 WebViewImpl* view = *it; 195 WebViewImpl* view = *it;
196 m_frozenViews.add(view); 196 m_frozenViews.add(view);
197 views.append(view); 197 views.append(view);
198 view->setIgnoreInputEvents(true); 198 view->setIgnoreInputEvents(true);
199 view->chromeClient().notifyPopupOpeningObservers();
199 } 200 }
200 201
201 const WebFrameWidgetsSet& widgetImpls = WebFrameWidgetImpl::allInstances (); 202 const WebFrameWidgetsSet& widgetImpls = WebFrameWidgetImpl::allInstances ();
202 WebFrameWidgetsSet::const_iterator widgetImplsEnd = widgetImpls.end(); 203 WebFrameWidgetsSet::const_iterator widgetImplsEnd = widgetImpls.end();
203 for (WebFrameWidgetsSet::const_iterator it = widgetImpls.begin(); it != widgetImplsEnd; ++it) { 204 for (WebFrameWidgetsSet::const_iterator it = widgetImpls.begin(); it != widgetImplsEnd; ++it) {
204 WebFrameWidgetImpl* widget = *it; 205 WebFrameWidgetImpl* widget = *it;
205 m_frozenWidgets.add(widget); 206 m_frozenWidgets.add(widget);
206 widgets.append(widget); 207 widgets.append(widget);
207 widget->setIgnoreInputEvents(true); 208 widget->setIgnoreInputEvents(true);
209 widget->chromeClient().notifyPopupOpeningObservers();
dgozman 2016/05/26 19:27:29 We don't need this.
kozy 2016/05/26 19:38:02 Done.
208 } 210 }
209 211
210 // 2. Notify embedder about pausing. 212 // 2. Notify embedder about pausing.
211 if (agent->client()) 213 if (agent->client())
212 agent->client()->willEnterDebugLoop(); 214 agent->client()->willEnterDebugLoop();
213 215
214 // 3. Disable active objects 216 // 3. Disable active objects
215 WebView::willEnterModalLoop(); 217 WebView::willEnterModalLoop();
216 218
217 // 4. Process messages until quitNow is called. 219 // 4. Process messages until quitNow is called.
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method) 666 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method)
665 { 667 {
666 return method == "Debugger.pause" 668 return method == "Debugger.pause"
667 || method == "Debugger.setBreakpoint" 669 || method == "Debugger.setBreakpoint"
668 || method == "Debugger.setBreakpointByUrl" 670 || method == "Debugger.setBreakpointByUrl"
669 || method == "Debugger.removeBreakpoint" 671 || method == "Debugger.removeBreakpoint"
670 || method == "Debugger.setBreakpointsActive"; 672 || method == "Debugger.setBreakpointsActive";
671 } 673 }
672 674
673 } // namespace blink 675 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/WebFrameWidgetImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698