Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2011673002: [DevTools] Add notifyPopupOpeningObservers call before running debug loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
index 122af3f279a37ac9eb57604f1b5e876c577e90a5..b1e118df8faab4ecb8d1bd04e6f3771d95c7a84f 100644
--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
@@ -196,6 +196,8 @@ private:
m_frozenViews.add(view);
views.append(view);
view->setIgnoreInputEvents(true);
+ if (Page* page = view->page())
+ page->chromeClient().willEnterDebugLoop();
}
const WebFrameWidgetsSet& widgetImpls = WebFrameWidgetImpl::allInstances();
@@ -205,6 +207,8 @@ private:
m_frozenWidgets.add(widget);
widgets.append(widget);
widget->setIgnoreInputEvents(true);
+ if (Page* page = widget->page())
+ page->chromeClient().willEnterDebugLoop();
}
// 2. Notify embedder about pausing.

Powered by Google App Engine
This is Rietveld 408576698