third_party/WebKit/Source/web/ChromeClientImpl.cpp - Issue 2011673002: [DevTools] Add notifyPopupOpeningObservers call before running debug loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2011673002: [DevTools] Add notifyPopupOpeningObservers call before running debug loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/page/ChromeClient.h ('K') | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

index ab5b0e7b38da10ede99bb915ea7f6405b1e21267..cd24cb5cbe3a140d6950eb4aa2ad28cddf624be9 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

@@ -1114,4 +1114,9 @@ double ChromeClientImpl::lastFrameTimeMonotonic() const

return m_webView->lastFrameTimeMonotonic();

}

+void ChromeClientImpl::willEnterDebugLoop() const

+ notifyPopupOpeningObservers();

} // namespace blink