third_party/WebKit/Source/core/page/ChromeClient.h - Issue 2011673002: [DevTools] Add notifyPopupOpeningObservers call before running debug loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.h

Issue 2011673002: [DevTools] Add notifyPopupOpeningObservers call before running debug loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/debugger/suspend-spin-button-on-pause-expected.txt ('k') | third_party/WebKit/Source/web/ChromeClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/ChromeClient.h

diff --git a/third_party/WebKit/Source/core/page/ChromeClient.h b/third_party/WebKit/Source/core/page/ChromeClient.h

index 2fbe9321c3fee26b32e4b94913affab1d4d814c2..b8c7f2da9f2f9cb3e58d964ab8752c88638b6005 100644

--- a/third_party/WebKit/Source/core/page/ChromeClient.h

+++ b/third_party/WebKit/Source/core/page/ChromeClient.h

@@ -281,6 +281,8 @@ public:

// Returns the time of the beginning of the last beginFrame, in seconds, if any, and 0.0 otherwise.

virtual double lastFrameTimeMonotonic() const { return 0.0; }

+ virtual void willEnterDebugLoop() const {}

dgozman 2016/05/26 00:08:56 Should not go through this interface, call it on C

kozy 2016/05/26 00:31:14 Done.

protected:

~ChromeClient() override { }