[DevTools] Add notifyPopupOpeningObservers call before running debug loop

third_party/WebKit/Source/core/page/ChromeClient.h

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 263 matching lines @@
     // Called when observed XHR, fetch, and other fetch request with non-GET
     // method is initiated from javascript. At this time, it is not guaranteed
     // that this is comprehensive.
     virtual void didObserveNonGetFetchFromScript() const {}
 
     virtual PassOwnPtr<WebFrameScheduler> createFrameScheduler(BlameContext*) = 0;
 
     // Returns the time of the beginning of the last beginFrame, in seconds, if any, and 0.0 otherwise.
     virtual double lastFrameTimeMonotonic() const { return 0.0; }
 
+    virtual void willEnterDebugLoop() const {}

[dgozman, 2016/05/26 00:08:56]

Should not go through this interface, call it on ChromeClientImpl directly.

[kozy, 2016/05/26 00:31:14]

Done.

+
 protected:
     ~ChromeClient() override { }
 
     virtual void showMouseOverURL(const HitTestResult&) = 0;
     virtual void setWindowRect(const IntRect&) = 0;
     virtual bool openBeforeUnloadConfirmPanelDelegate(LocalFrame*, bool isReload) = 0;
     virtual bool openJavaScriptAlertDelegate(LocalFrame*, const String&) = 0;
     virtual bool openJavaScriptConfirmDelegate(LocalFrame*, const String&) = 0;
     virtual bool openJavaScriptPromptDelegate(LocalFrame*, const String& message, const String& defaultValue, String& result) = 0;
     virtual void printDelegate(LocalFrame*) = 0;
 
 private:
     bool canOpenModalIfDuringPageDismissal(Frame* mainFrame, DialogType, const String& message);
     void setToolTip(const HitTestResult&);
 
     LayoutPoint m_lastToolTipPoint;
     String m_lastToolTipText;
 
     FRIEND_TEST_ALL_PREFIXES(ChromeClientTest, SetToolTipFlood);
 };
 
 } // namespace blink
 
 #endif // ChromeClient_h